317348 - new mail indicated on folder when there is no new mail

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Wayne Mery (:wsmwk)]

IMAP.  version 1.6a1 (20051113)  two email accounts open.  accounts are SSL and multiple PC's access these 2 imap accounts - one PC at home and one at work. 

account #1 at work: click folder, icon indicates folder has new mail, click a different folder, icon changes back to indicate no new mail. doesn't happen with account #2 and not all folders, just one folder now but it had been two folders - something cleared the condition in the other folder.

The above didn't happen for several days after I installed this build - so one must suspect corruption.  weirdness is similar to Bug 316944 and Bug 313694

Perhaps related (but I encountered this before this build) ... *Account #2* at work (where I am now) totally stopped getting new mail 12 hours ago, at about the time I accessed account #2 on the home PC. So the PC at home received mail in account #2 (and I assume still is) that the PC at work isn't getting.

Comment 1

[Wayne Mery (:wsmwk)]

Attachment: folder icon example 1

notice thread pane shows no new messages - there are none. Yet, folder icon indicates new messages

Comment 2

[Wayne Mery (:wsmwk)]

Attachment: folder icon example 2

notice thread pane shows there was 1 new message - after opening the folder it is no longer new, it has been read. Yet, folder icon indicates new messages.


In both attachment cases if I click a different folder it goes back to regular folder icon. but click the moz folder and icon changes to "new messages"

Comment 3

[Wayne Mery (:wsmwk)]

prior builds used 
20050908 1.6a
20051017 1.6a
20051030 1.6a

don't think problem appeared on 20051030. (but this build 20051103 is crashing)

Comment 4

[Chris Watson]

I have noticed this occurs when an account tree is collapsed and the Inbox for that account has an unread junk message or filtered message in it.  The Icon shows an unread message is in a folder in the account but opening the account to view the unread message causes the filter to process and the folder will no longer have an unread message in it.  When using the "Next" button from viewing messages in an other account, the "Next" process no longer works once the "Next" process moves to the account where the filters have not yet run.  The only way to start again is to go to find the next unread message manually and then the "Next" button process will work again.

A possible solution to both problems would be to process the filters for ALL acounts after "Get Mail" is run, and then clear the flags on folders and account headers for folders which no longer have unread mail because of message moves as a result of filter processing.

Comment 5

[David :Bienvenu]

Attachment: proposed fix

I'll attach a description of what's going on in a sec, but FF keeps crashing, so I want to get this committed.

Comment 6

[David :Bienvenu]

OK, here's one way to recreate this symptom:

1. Set up a virtual folder that shows unread message in a set of folders
2. send yourself mail that will show up in the virtual folder, e.g., mail that will get filtered into a folder that is part of the scope of the virtual folder
3. Select the virtual folder
4. Delete the new message
5. go to a different folder.
6. Mouse over the folder that actually received the new unread message

That will cause the new flag to appear for that folder.

What's going on is that we're sticking the new messages in the new list for that folder, but we're not updating the new list when the messages are deleted - doing that might be hard. So the fix is to make sure messages really exist when we're applying the folder's new list to the db.
 

Comment 7

[David :Bienvenu]

I've checked my fix into the trunk and 2.0 branch - please re-open if this is still happening in tomorrow's 2.0 nightly build.

Comment 8

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.3 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620, the new mail indicator is working as expected