317369 - make use of textbox's clickSelectsAll property for the location bar and help

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[:Gavin Sharp [email: [e-mail]]]

See 312642 comment 0.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Fixes this without regressing bug 308819 (had to change the textbox event handlers to the bubbling phase instead of capturing). Didn't think it was worth adding a pref listener, since there isn't one currently anyways. This is still per-window, but that also matches current behavior.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 207283 [details] [diff] [review]
patch

Asaf, feel free to review if you can find the time :)

Comment 3

[Asaf Romano (gone)]

Comment on attachment 207283 [details] [diff] [review]
patch

>Index: browser/base/content/browser.js
>===================================================================

>-function displaySecurityInfo()
>+function displaySecurityInfo(aEvent)
> {
>   BrowserPageInfo(null, "securityTab");
>+  aEvent.preventBubble();
> }

null-check aEvent.

>Index: browser/base/content/browser.xul
>===================================================================

>+#ifdef XP_UNIX
>+                 clickSelectsAll="false"
>+#else
>+                 clickSelectsAll="true"
>+#endif

This really isn't necessary.

>           </deck>
>           <hbox id="urlbar-icons">
>-            <button type="menu" style="-moz-user-focus: none" class="plain" id="feed-button" chromedir="&locale.dir;">
>+            <button type="menu" style="-moz-user-focus: none" class="plain"
>+                    id="feed-button" chromedir="&locale.dir;"
>+                    onclick="event.preventBubble();">

one attribute per line please.

>             </button>
>-            <image id="lock-icon" onclick="displaySecurityInfo()"/>
>+            <image id="lock-icon" onclick="displaySecurityInfo(event)"/>

While you're here, a semicolon would be nice.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch v2

Address review comments.

Comment 5

[Asaf Romano (gone)]

Comment on attachment 207322 [details] [diff] [review]
patch v2

r=mano

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch v3

don't forget the searchbar

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js; new revision: 1.552;
mozilla/browser/base/content/browser.xul; new revision: 1.276;
mozilla/browser/base/content/search.xml; new revision: 1.35;
mozilla/toolkit/content/widgets/textbox.xml; new revision: 1.26;

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch for help

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Attachment: real patch for help

Comment 10

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/help/content/help.js; new revision: 1.40;
mozilla/toolkit/components/help/content/help.xul; new revision: 1.30;

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 207414 [details] [diff] [review]
patch v3

mozilla/browser/base/content/search.xml 	1.25.2.11 	mozilla/browser/base/content/browser.xul 	1.268.2.10 	mozilla/browser/base/content/browser.js 	1.479.2.58

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 208220 [details] [diff] [review]
real patch for help

mozilla/toolkit/components/help/content/help.js 	1.37.2.2 	mozilla/toolkit/components/help/content/help.xul 	1.26.2.2