317404 - Importing an empty ldif address confuses thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Thomas Klausner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7.12) Gecko/20050919 Firefox/1.0.7
Build Identifier: Thunderbird 1.5 (20051025)

When one tries to import an empty ldif file as address book into thunderbird,
they usual import procedure is not carried through to the end; the user can cancel out, but there is no explanation what happened.

Reproducible: Always

Steps to Reproduce:
Steps to reproduce the problem:
1. create an empty ldif file
2. import it (tools/import):
   a) select "Address Books"
   b) select "Text File (LDIF, .tab, .csv, .txt)"
   [file chooser pops up]
   c) select the file created in step 1, "Open"
At this point the active (modal) dialog for the address book is the dialog from step 2b; "Back" and "Next" are greyed out and only "Cancel" is possible.
thunderbird is not using any CPU (according to task manager) and nothing happens.
Actual Results:  
Unexpected window appears with unusual button possibilities.

Expected Results:  
Either finish the import (importing nothing) or complain that the file is empty.

Comment 1

[Mark Banner (:standard8)]

Confirming on 1.6a1 (20051121)

This looks like a regression from bug 256826 (back at the end of 2004!), an extra string wasn't defined for TB. The fix is simple (patch coming up), but it'll be a l10n change for 1.5 branch if its wanted.

I'm requesting blocking 1.8.0.1: this is a missing dialog on importing an empty address book, you can still use the software though it may be confusing to the user, affects thunderbird only, and requires one string addition to fix (I'm won't be surprised if drivers don't want it for 1.8.0.1 - its up to drivers).

Comment 2

[Mark Banner (:standard8)]

Attachment: Add missing string in importMsg.properties

This adds the missing string & fixes the bug.

I did a diff on between the mailnews and mail versions of this file and this was the only missing string (there had been additions to the mail version but that'll be ok for tb).

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 203927 [details] [diff] [review]
Add missing string in importMsg.properties

checked in on trunk:
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/importMsgs.properties,v  <--  importMsgs.properties
new revision: 1.4; previous revision: 1.3

Requesting approval for branch - I think this should go in at some stage if possible as users may get confused by no dialog coming up. See comment 2 for other reasons. Note that this affects l10n.

Comment 4

[Benjamin Smedberg]

The branch is l10n-frozen... we are more likely to be able to take a branch patch which hardcodes a fallback (English) string in the code.

Comment 5

[Scott MacGregor]

1.8.0.1. is for security issues. This is not a critical issue. moving to 1.8.1 nomination.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 203927 [details] [diff] [review]
Add missing string in importMsg.properties

Removing approval request flag per previous comments, until we get approval flags for 1.8.1.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 203927 [details] [diff] [review]
Add missing string in importMsg.properties

Hmm, looks like 1.8 branch opened up again, therefore requesting approval for 1.8.1 for addition of this missing string to thunderbird.

Comment 8

[Mark Banner (:standard8)]

This was checked into trunk a while ago, therefore I'm marking as fixed. I'll
check into branch if the patch eventually gets approval.