317489 - Email preferences are not set for the new admin user

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Max Kanat-Alexander]

I just installed today's CVS Bugzilla, and I just noticed that when I went to the email-prefs screen, all my email prefs were disabled. I'm the checksetup-created admin user -- do we forget to create emailprefs for the admin user?

Or are they cleared the first time I visit userprefs.cgi, for some reason?

Does this also affect 2.20?

Comment 1

[Frédéric Buclin]

I can reproduce the problem using 2.20+. The admin does't get anything. All "but not when (overrides above):" checkboxes are checked, all others are not.

Comment 2

[Frédéric Buclin]

Attachment: non-working (?) and untested patch, v0.1

Ideally, we should call Bugzilla::User::insert_new_user() as suggested in this patch, but I suppose we cannot do that in checksetup.pl? In this case, we have to copy the code from this function into checksetup.pl, which is ugly (duplicated code).

Comment 3

[Max Kanat-Alexander]

Comment on attachment 204434 [details] [diff] [review]
non-working (?) and untested patch, v0.1

Works for me, on the tip.

Yeah, we should have always been doing that. I wonder why we weren't...

I only have two nits:

(1) Move the "require Bugzilla::User" up into the "Global Utility Library" section of checksetup. I'd like to keep all the "require" statements in one place.

(2) You don't actually need that 'import' statement, because you're doing the whole Bugzilla::User::insert_new_user.

Comment 4

[Frédéric Buclin]

Attachment: patch, v1

This one has been tested. ;)

Comment 5

[Max Kanat-Alexander]

Comment on attachment 204482 [details] [diff] [review]
patch, v1

Sure, looks good to me based on interdiff inspection. :-)

Comment 6

[Frédéric Buclin]

Attachment: backport for 2.20, v1

Comment 7

[Max Kanat-Alexander]

Comment on attachment 204486 [details] [diff] [review]
backport for 2.20, v1

r=mkanat by inspection

Comment 8

[Frédéric Buclin]

tip:

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.455; previous revision: 1.454
done

2.20:

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.412.2.12; previous revision: 1.412.2.11
done