Closed Bug 317556 Opened 19 years ago Closed 18 years ago

filter option "forward message to" does not allow one letter user part for email address

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: cignangulo, Assigned: Bienvenu)

Details

(Keywords: fixed1.8.1, verified1.8.1.3)

Attachments

(1 file, 2 obsolete files)

third time the charm
1.30 KB, patch
mscott
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Thunderbird 1.5rc1 (20051025) [pls substitute w/ proper id!]

declines email addresses with a one letter user part for new message filters with action "forward message to".

Reproducible: Always

Steps to Reproduce:
1.  Tools > Message Filters
2.  New
2a. (unnecessary for reproduction, but normally) set arbitrary filter condition
3.  Peform these actions: Forward Message to
4.  Enter address like a@user.tld
5.  OK
Actual Results:  
Dialog window "Alert" with message: Enter a valid email address to forward to.

Expected Results:  
Acceptance of input without error message.

RFC 2821 (http://www.ietf.org/rfc/rfc2821.txt) only defines maximum length, no minumum:
> local-part
> The maximum total length of a user name or other local-part is 64 characters.

Sending messages, identities, receiving of messages generally allow single-letter local-parts in Tb.
Attached patch proposed fix (obsolete) — — Splinter Review 
indexOf seems to return 0-based indices...
Assignee: mscott → bienvenu
Status: UNCONFIRMED → ASSIGNED
Attachment #204065 - Flags: superreview?(mscott)
Comment on attachment 204065 [details] [diff] [review]
proposed fix

I don't see us using the variable fromMailbox anywhere.
Attached patch correct fix (obsolete) — — Splinter Review 
sigh, mailnews instead of mail dir...
Attachment #204065 - Attachment is obsolete: true
Attachment #204068 - Flags: superreview?(mscott)
Attachment #204065 - Flags: superreview?(mscott)
Attachment #204068 - Attachment is obsolete: true
Attachment #204068 - Flags: superreview?(mscott)

        Attachment #204069 -
        Flags: superreview?(mscott)

    
  

        Attachment #204069 -
        Flags: superreview?(mscott) → superreview+

    
  
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED

    
    

    
  
verified fixed 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620 - steps to reproduce working fine - adding verified keyword
Keywords: verified1.8.1.3

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: