31759 - Translation of characters greater than ascii128 wrong.

Status: VERIFIED WORKSFORME

(Core :: Networking, defect, P3)

Description

[Kastellanos Nikos]

Problem in translation of characters in


hard coded queries.


bug example at http://www.software.gr/mozillatest.html

Comment 1

[rods (gone)]

eric, this is yours

Comment 2

[Eric Pollmann]

The test case states (and I verified by testing with today's build) that the
problem is not with form submission, but with clicking on a link that has the
query hard-coded in it, for example:

<A HREF="mozillatest2.nkm?Value=Greek_Ελληνικά">Link</A>

Form submission of this value in a text area, for example, works fine.
Clicking on an anchor, the characters are getting translated incorrectly. 

The routine in form submission, that does the work of encoding variable/value
strings before passing it off to OnLinkClick is here:

  mozilla/layout/html/forms/src/nsFormFrame::URLEncode

The call that is not working is here, and it seems like it should call a routine
similar to that above before passing on the query string to OnLinkClick:

  mozilla/layout/base/src/nsGenericElement::TriggerLink

Handing off to netlib to look at (Warren seems to have written most of
TriggerLink).  Please let me know if I can help.

Comment 3

[Warren Harris]

I just fixed it to propagate an error. This was originally Vidur's code.

Comment 4

[Tom Mraz]

I've looked at the URL and it seems to me it's fixed now. (I can't change the
status of the bug.)

Comment 5

[Eric Pollmann]

Thanks Tom!  Yes, this bug is no longer present.  To verify, go the testcase in 
the URL.  Click on the form submit button.  Notice what is in the URL bar.  
Click back, then click on the link.  The contents of the URL bar should be the 
same in both cases.  (Also, the text on the next page should contain greek 
characters in both cases.)

Comment 6

[ckritzer (gone)]

Marking VERIFIED WORKSFORME on:
- MacOS9    2001-01-09-08-T Commercial
- LinuxRH62 2001-01-09-08-T Commercial
- Win98     2001-01-09-08-T Commercial