Comment wrong in nsSelection.cpp

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
Layout
P5
trivial
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Hixie (not reading bugmail), Assigned: Gavin)

Tracking

Trunk
mozilla1.9alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
It seems to me that the comment in nsSelection.cpp in nsTypeSelection::AddRange(), namely:

5594 NS_IMETHODIMP
5595 nsTypedSelection::AddRange(nsIDOMRange* aRange)
5596 {
5597   if (!aRange) return NS_ERROR_NULL_POINTER;
5598 
5599   // This inserts a table cell range in proper document order
5600   //  and returns NS_ERROR_FAILURE if range doesn't contain just one table 
           cell
5601   PRBool didAddRange;
5602   nsresult result = addTableCellRange(aRange, &didAddRange);
5603   if (NS_FAILED(result)) return result;

...should say NS_OK, not NS_ERROR_FAILURE.
Created attachment 218603 [details] [diff] [review]
fix comment

Looks correct to me:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsSelection.cpp&rev=3.225&mark=3931,3958#3926
Assignee: general → gavin.sharp
Status: NEW → ASSIGNED
Attachment #218603 - Flags: superreview?(roc)
Attachment #218603 - Flags: review?(roc)
Component: DOM → Layout
OS: Linux → All
QA Contact: ian → layout
Hardware: PC → All
Priority: -- → P5
Target Milestone: --- → mozilla1.9alpha
Attachment #218603 - Flags: superreview?(roc)
Attachment #218603 - Flags: superreview+
Attachment #218603 - Flags: review?(roc)
Attachment #218603 - Flags: review+
mozilla/layout/generic/nsSelection.cpp 	3.227
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.