If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Double-Clicking on empty space below tree gives col.value has no properties in chrome://global/content/bindings/tree.xml Line Number= 710

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Toolkit
XUL Widgets
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Mime Čuvalo, Assigned: Nickolay_Ponomarev)

Tracking

({testcase})

Trunk
mozilla1.9alpha1
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

Doing a double-click on a space below where there any rows gives:
col.value has no properties URL= chrome://global/content/bindings/tree.xml Line Number= 710

I can reproduce this problem in FireFTP 0.90 (available at http://fireftp.mozdev.org) with Firefox 1.5

It seems the 
Looking back through the source the problem might be here (I think):
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=tree.xml&branch=&root=/cvsroot&subdir=mozilla/toolkit/content/widgets&command=DIFF_FRAMESET&rev1=1.13&rev2=1.14

changed from this:
var column = document.getElementById(col.value);
var cycler = column.hasAttribute('cycler');
if (!cycler && obj.value != "twisty" && b.view.isContainer(ro
w.value))
    b.view.toggleOpenState(row.value);

to this:
var col = {};
var obj = {};                                                          
b.getCellAt(event.clientX, event.clientY, {}, col, obj);               
// Cyclers and twisties respond to single clicks, not double clicks
if (!col.value.cycler && obj.value != "twisty")    
    this.parentNode.changeOpenState(row);

which isn't exactly the same logic.  The new version (the one in place doesn't check whether col.value is null (which it is in the case that I present).  If you look a couple line above in the source code you'll see the single-click event does check for this:

if (!col.value) return;

I suppose the same should be done in the double-click event.

Reproducible: Always

Steps to Reproduce:
1. Open up FireFTP v0.90 (@ http://fireftp.mozdev.org) with Firefox 1.5
2. On one of the the local directory tree place mouse over whitespace below the last row in the tree.
3. Do a double-click.  Error message should pop up.
4. Look here for an example: http://chasaidthekitty.com/colvalue.png
(Reporter)

Comment 1

12 years ago
This is still a bug in Bon Echo.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3

chrome://global/content/bindings/tree.xml
Line 708

This should be an easy fix.
(Assignee)

Comment 2

11 years ago
Created attachment 225226 [details]
testcase

Steps to reproduce: select the first tree item, double-click on the free space below.
(Assignee)

Updated

11 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: testcase
Version: unspecified → Trunk
(Assignee)

Comment 3

11 years ago
Created attachment 225227 [details] [diff] [review]
missing null-check

Patch as suggested. You could get this looked at earlier by submitting the patch yourself :)
Assignee: nobody → asqueella
Status: NEW → ASSIGNED
Attachment #225227 - Flags: first-review?(enndeakin)

Comment 4

11 years ago
Comment on attachment 225227 [details] [diff] [review]
missing null-check

OK, but please also update the xpfe version to match
Attachment #225227 - Flags: first-review?(enndeakin) → first-review+
(Assignee)

Comment 5

11 years ago
Created attachment 225272 [details] [diff] [review]
patch for checkin (same as previous with xpfe part included)

Sure.
Attachment #225227 - Attachment is obsolete: true
Attachment #225272 - Flags: first-review+
(Assignee)

Updated

11 years ago
Whiteboard: [checkin needed]
mozilla/xpfe/global/resources/content/bindings/tree.xml 	1.57 	mozilla/toolkit/content/widgets/tree.xml 	1.32 
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha1
You need to log in before you can comment on or make changes to this bug.