Closed Bug 317654 Opened 19 years ago Closed 19 years ago

Extension installation hits fatal error in nsExtensionManager.js

Categories

(Toolkit :: Add-ons Manager, defect)

x86
All
defect
Not set
major

Tracking

()

RESOLVED WORKSFORME
mozilla1.8.1beta2

People

(Reporter: sparr0, Assigned: robert.strong.bugs)

Details

Attachments

(1 obsolete file)

User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 I have just installed Firefox 1.5RC3. Any extension installation that does not abort for other reasons (such as unmet version requirements) dies with this error: Error: installLocation has no properties Source File: file:///opt/firefox/components/nsExtensionManager.js Line: 3233 Reproducible: Always Steps to Reproduce: 1. Install StumbleUpon or AdBlockPlus extension or any other that is compatible with FireFox 1.5RC3 Actual Results: error dialog, error message in javascript console, extension not installed Expected Results: successful installation
Rob, this is another "installLocation has no properties error", and this build has the fix from bug 308172. Seems like this is a common error, maybe it needs better error handling?
I've seen this a couple of times when debugging other people's installed extensions and this has always been caused by a bug elsewhere in the code that does not throw until it reaches this part of the code. So, I have been fixing the other parts of the code and I am leaving the fix for this part until after I have the other ones under control. Clarence, are you still experiencing this problem? If so, it would be helpful if I could get your extension files so I can debug it to find to root cause. Can you zip up your profile's extensions directory along with the extensions.rdf, extensions.cache, and extensions.ini files that are located inside your profile's directory and email them to me? They are almost always larger than the size limit for attachments for a bug. http://www.mozilla.org/support/firefox/profile *IMPORTANT* This file is located in your profile directory and not the same as the Extensions.rdf that is located in your profile's extensions directory if there is one in that location - note that the one in your profile directory is all lowercase and the one in the extensions directory is Extensions.rdf
Assignee: nobody → robert.bugzilla
I am using 1.5 proper now and have not experienced this bug again (with 8 extensions successfully installed now). I apologize for not keeping the relevant files handy when I removed 1.5RC3.
No problem, chances are I have already received files for the same bug were experiencing and have patched it in another bug. I'm going to use this bug for protecting against the "installLocation has no properties" error.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Firefox 2 alpha2
Flags: blocking-firefox2+
Hi, I'm experiencing this problem as well, except I'm using FF 1.5.0.1 & WinXP. I can't install any more extensions now. My currently installed extensions are: DOM Inspector (1.8.0.1) Talkback (1.5.0.1) undoclosetab (2551204) SessionSaver .2 (d1 nightly 30) EditCSS (0.3.4) CustomizeGoogle (0.43) PDF Download (0.6) Gmail Notifier (0.5.5.2) Close Button (0.2) HashColouredTabs (0.3.3) This is the order in which the extension manager lists them, and it's more or less the order in which I've installed them. So, if the extension manager lists them in the correct order, I guess it's HashColouredTabs which is causing the problem, no? If anyone has a suggestion for fixing this, please feel free to help :-) Thanks!
(In reply to comment #5) Ludootje, follow the directions for sending me the related files in comment #2
Whiteboard: 1d
Target Milestone: Firefox 2 alpha2 → Firefox 2 beta1
Attached file forget (obsolete) —
Attachment #224302 - Attachment description: This is the code that the reporter posted. → forget
Attachment #224302 - Attachment is obsolete: true
pushing out non-critical-path bugs to b2
Target Milestone: Firefox 2 beta1 → Firefox 2 beta2
How common is this? Are we still getting reports of the problem?
Whiteboard: 1d → [at risk]
Flags: blocking-firefox2+ → blocking-firefox2-
I have been patching bugs that have caused this error since before 1.5 was released and I fixed all the ones I could reproduce. I suspect there may still be a couple of cases where this can occur but I suspect they are rare edgecases and all of my 30+ testcases are fixed. I've been trying to reproduce this for the last couple of weeks without success. I also don't want to just protect against this throwing since the root cause has always been prior to this throwing. Resolving -> WFM.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
Whiteboard: [at risk]
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: