317830 - Refactor places query object

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect, P3)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Get rid of the bulky and growing query interface and simply make the query object implement a writable property bag. Different properties can have different types. 

Modifier prefixes can be used within the property names to specify special options, e.g.:

query.setProperty("foo", "*")    <-- match if first class property foo is set to 
                                     anything
query.setProperty("!foo", "*")   <-- match if first class property foo is not set
query.setProperty("A:foo", "*")  <-- match if annotation foo is set to anything
query.setProperty("!A:foo", "*") <-- match if annotation foo is not set

...

or similar.

Comment 1

[Dietrich Ayala (:dietrich)]

i'm not sure that exchanging explicit method/property names for a generic api with cryptic prefixing is really the way to go here.

i'm going to wontfix this; if we decide to refactor let's do it under a new bug, in the context of the recent Places changes.

Comment 2

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv