317911 - weird nsCOMPtr<> construction in nsAddrDatabase ctor

Status: VERIFIED FIXED

(MailNews Core :: Address Book, defect)

Description

[Bernard Alleysson]

m_dbName is declared as "nsCOMPtr<nsIFile> m_dbName;" in nsAddrDatabase.h
and is initialized with m_dbName("") in nsAddrDatabase.cpp, from a char * ?!

Comment 1

[Bernard Alleysson]

Attachment: use default nsCOMPtr<> ctor

bugzilla, could you review this trivial patch, thanks !

Comment 2

[Bernard Alleysson]

Comment on attachment 204267 [details] [diff] [review]
use default nsCOMPtr<> ctor

oops, Could you review this trivial patch, thanks !

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 204267 [details] [diff] [review]
use default nsCOMPtr<> ctor

This is a hangover from when I changed m_dbName from nsFileSpec to nsCOMPtr<nsIFile>.

I don't see a problem with using the default nsCOMPtr<> constructor here.

Comment 4

[Bernard Alleysson]

Mark, could you do the checkin for me ? thx

Comment 5

[Mark Banner (:standard8)]

Assigning to bernard as he provided the patch for the fix.

Comment 6

[Mark Banner (:standard8)]

Patch checked in, marking fixed.

cvsroot/mozilla/mailnews/addrbook/src/nsAddrDatabase.cpp,v  <--  nsAddrDatabase.cpp
new revision: 1.139; previous revision: 1.138

Thanks for the fix Bernard :-)

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED via code inspection: LXR