317964 - shortcuts.xhtml has wrong layout (es-ES l10n)

Status: RESOLVED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[Andrés G. Aragoneses]

We have a translation error in es-ES help: there is an extra <td> tag that causes wrong layout of the table.

Comment 1

[Andrés G. Aragoneses]

Attachment: Proposed patch

Patch attached.

Comment 2

[Axel Hecht [:Pike]]

I tend to leave this open for 1.5.0.1, unless you can show a screenshot that
convinces me to block and respin es-ES.

Comment 3

[Andrés G. Aragoneses]

Attachment: Screenshot of the problem

Well, this is the screenshot. I am not trying to convince you, I admit this is a cosmetical bug that should be fixed, but you decide if it must be done now or later. Thanks for reviewing!

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 204329 [details] [diff] [review]
Proposed patch

trivial fix, and likely good for 1.5.0.1.

But definitly not a reason for a respin, thanks for the screenshot.

Comment 5

[Axel Hecht [:Pike]]

knocte, just realized that you refused to read bugmail. Don't dare doing that
again. Next time I'll blame you in person for not releasing any particular
thunderbird locale.

Comment 6

[Andrés G. Aragoneses]

Axel, excuse me if I am wrong but I suppose you are talking about the last comment you put in bug 318984 (https://bugzilla.mozilla.org/show_bug.cgi?id=318984#c3), which was inserted *after* (2005-12-06 09:51 PST) I did this approval re-request (dated 2005-12-04 10:24:05 PST, as https://bugzilla.mozilla.org/show_activity.cgi?id=317964 is stating), not before. As you can see, I read bugmail, but haven't been so quick to remove myself the re-approval when I saw that comment.

And don't blame over anything about Thunderbird, because we have other persons in charge of that matter (http://wiki.mozilla.org/L10n:Localization_Teams#Spanish.2C_Spain_.28es-ES.29). The only thing I can say is that *I think* it was decided to wait for the 1.5 release that was going to be public soon (supposedly), instead of dealing with more problems related to installers. During TB 1.0.x first versions cycles, I didn't even have any responsabilities yet over the localization of any Mozilla products.

Comment 7

[Fernando García Gómez, stripTM]

We are requesting approval now because of 1.5.1 launching

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 204329 [details] [diff] [review]
Proposed patch

I doubt this will make it, even once we finalize the process.

Comment 9

[RickieES aka Ricardo Palomares]

This bug is solved for 2.0. knocte?

Comment 10

[RickieES aka Ricardo Palomares]

Taking over so we can clean up the list of alive bugs...

Comment 11

[RickieES aka Ricardo Palomares]

Shortcuts.xhtml looks Ok for Firefox 2.0, so I'm closing this bug.