317975 - Memory leaks via PK11_ListCerts

Status: RESOLVED DUPLICATE of bug 291228

(NSS :: Libraries, defect)

Description

[Simon Fraser [no longer active]]

I'm seeing a lot of memory leaks via a call to PK11_ListCerts(). The leak stacks look like:

		PK11_ListCerts
		NSSTrustDomain_TraverseCertificates
		nssPKIObjectCollection_Traverse
		pk11ListCertCallback
		STAN_GetCERTCertificateName
		get_cert_instance
		nssCryptokiObject_Clone
		nssUTF8_Duplicate
		nss_ZAlloc
		PR_Calloc 

My guess is that the leak is in STAN_GetCERTCertificateName(): does 'instance' need to be destroyed?

http://lxr.mozilla.org/mozilla/source/security/nss/lib/pki/pki3hack.c#693

Comment 1

[Kai Engert [:KaiE:]]

I think this is an NSS bug?

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Simon, is this a duplicate of bug 291228 ?

Comment 3

[Wan-Teh Chang]

Simon seems right. I think STAN_GetCERTCertificateName should
destroy 'instance' because fill_CERTCertificateFields, the
other caller of get_cert_instance, destroys 'instance':

char * 
STAN_GetCERTCertificateName(PLArenaPool *arenaOpt, NSSCertificate *c)
{
    nssCryptokiInstance *instance = get_cert_instance(c);
    char *nickname;
    nickname = STAN_GetCERTCertificateNameForInstance(arenaOpt, c, instance);
    if (instance) {
        nssCryptokiObject_Destroy(instance);
    }
    return nickname;
}

Comment 4

[Wan-Teh Chang]

Nelson, this bug is indeed a duplicate of bug 291228.

*** This bug has been marked as a duplicate of 291228 ***