318031 - Cloning a bug fails to copy the assignee over

Status: RESOLVED WONTFIX

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Marc Schumann [:Wurblzap]]

If you clone a bug, the fields get pre-filled so that the new bug will be assigned to the default assignee of the target component. I think the assignee of the cloned bug should be specified here by default.

This is not (or not only?) because of the JavaScript filling the assignee from the component -- the "value" attribute of the assignee input field is empty.

Steps to reproduce:
1) Create a bug, assigned to somebody else than the default assignee
2) Press "Clone this bug" on the new bug
3) Select the same product the original bug belongs to

Comment 1

[timeless]

gah. cloning bugs is totally broken. (and not really fixable)

the way it's misused at my office, they intend for bugs to get whichever component's default assignee. a better approach is to offer some way to pick between possibilities.

Comment 2

[Mike Durthaler]

(In reply to comment #1)
> gah. cloning bugs is totally broken. (and not really fixable)
> the way it's misused at my office, they intend for bugs to get whichever
> component's default assignee. a better approach is to offer some way to pick
> between possibilities.

Based on your comments, what is the status of this bug?  I'm guessing it was nearly 2 years before your response was added and 8 months until mine was.  I see this is of minor severity and probably should be closed.

What's your take on this?  I vote it's closed and an issue newly opened better pointing to a fixable one.

Mike

Comment 3

[Paul]

Please no.  The default assignee needs to know about the bug and controls who it is assigned to.
Allowing the cloner to choose assignee does not fit with the rest of the system.
Think about looking back at the activities, asking the question "When did this bug get assigned to someone other than default assignee?"

This bug is a WONTFIX for me.

Comment 4

[Marc Schumann [:Wurblzap]]

I agree in case the cloner doesn't have permission to choose the assignee. I disagree if he does -- then he wants to create a clone, an *exact copy* down to all fields.

Comment 5

[Frédéric Buclin]

The Bugzilla 3.0 branch is now locked to security bugs and dataloss fixes only. This bug doesn't fit into one of these two categories and is retargetted to 3.2 as part of a mass-change. To catch bugmails related to this mass-change, use lts081207 in your email client filter.

Comment 6

[Nitish Bezzala]

Attachment: Setting assign_to to the original bugs assigned_to

Comment 7

[Frédéric Buclin]

Comment on attachment 355019 [details] [diff] [review]
Setting assign_to to the original bugs assigned_to

>-$vars->{'assigned_to'}           = formvalue('assigned_to');
>+$vars->{'assigned_to'}           = $cloned_bug->assigned_to->email;

Obviously incorrect. $cloned_bug is undefined if you aren't cloning a bug, and Bugzilla will crash. Also, as Marc mentioned in comment 4, only users with editbugs privs should be allowed to copy the assignee for the cloned bug. Powerless users should not be allowed to; in this case, the default assignee should be selected (else you could obviously bypass privs checks).

Comment 8

[Nitish Bezzala]

Attachment: checking editbugs, and if cloned_bug

Comment 9

[Frédéric Buclin]

Comment on attachment 356654 [details] [diff] [review]
checking editbugs, and if cloned_bug

>+    $vars->{'assigned_to'} = $cloned_bug->assigned_to->email if ($has_editbugs);
>+}
>+
>+if (!$vars->{'assigned_to'}) {
>+    $vars->{'assigned_to'}       = formvalue('assigned_to');
> }

Hum.. this looks wrong to me. If I have editbugs privs, I cannot choose the assignee anymore by passing it to the URL. This is a regression. All you have to do is to pass $cloned_bug->assigned_to->email to formvalue() if the bugs is being cloned and the user has editbugs privs.

Comment 10

[Nitish Bezzala]

Attachment: If cloned bug and haseditbugs privs, set formvalue to original bugs assigned_to

Comment 11

[Frédéric Buclin]

Comment on attachment 377647 [details] [diff] [review]
If cloned bug and haseditbugs privs, set formvalue to original bugs assigned_to 

>-$vars->{'assigned_to'}           = formvalue('assigned_to');
>+if ($cloned_bug_id && $has_editbugs) {
>+    $vars->{'assigned_to'}           = formvalue('assigned_to', $cloned_bug->assigned_to->email);
>+} else {
>+    $vars->{'assigned_to'}           = formvalue('assigned_to');
>+}

Look at other fields. There are two big blocks where they are listed: one for cloned bugs starting at line 406, and the other one starting at line 455. You should move the code there. Also, this code won't work if the 'emailsuffix' parameter is not empty. You want ->login, not ->email. And I partially take back what I said in my previous comment. I just realized that we cannot pass values from the URL when cloning a bug, so we should respect that here too.

Comment 12

[Nitish Bezzala]

Attachment: used asigned_to->login, moved code to if and else block

Comment 13

[Frédéric Buclin]

Comment on attachment 408590 [details] [diff] [review]
used asigned_to->login, moved code to if and else block

The patch doesn't apply cleanly. Another checkin must have conflicted with it. Also, please reread my last comment about cloned fields.

Comment 14

[Frédéric Buclin]

Bugzilla 4.0 is restricted to security fixes only.

Comment 15

[Renata Ghisloti]

Attachment: Add assigned user as CC in cloned Bug

When cloning a bug, the assignee from the first bug is added in the CC list of the second bug. If the assignee is already in the CC list, it is simply ignored.

Comment 16

[Frédéric Buclin]

Comment on attachment 628846 [details] [diff] [review]
Add assigned user as CC in cloned Bug

This patch is unrelated to this bug. You are altering the CC list while this bug is about the assignee field not being set.

Comment 17

[Simon Green]

FWIW, I would want this marked as WONTFIX. Just because you are cloning a bug does not mean that the assignee should the assignee of the cloned bug. For example, if I fixed a Bugzilla bug, and glob cloned it for the bugzilla.mozilla.org product (because my code was that good!), then I definitely shouldn't be the default assignee.

I have created bug 1005780 to copy these values over to the CC: list however.

  -- simon

Comment 18

[:glob ✱]

i agree with simon - just because a bug is cloned doesn't mean it will have the same assignee or qa-contact by default.