Closed Bug 318073 Opened 19 years ago Closed 19 years ago

nsIProcess is not a service

Categories

(Toolkit :: View Source, defect)

Product:
Toolkit
Component:
View Source
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1alpha2

People

(Reporter: bzbarsky, Assigned: jason.barnabe)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

switch from getService to createInstance
1.28 KB, patch
mconnor
: review+
Details | Diff | Splinter Review 
See bug 172817 comment 131.  Doing that is Not Cool -- if nothing else, this will reuse the same nsIProcess for each view-source call, and reiniting one is not even guaranteed to work.
I'll fix it, but since this is not cool shouldn't this throw or something? Or is this just not cool in this one particular instance?
It's not cool to getService things that are not services.  Unfortunately, XPCOM has no way of knowing what's a service.

        Attachment #204413 -
        Flags: review?(mconnor)

        Attachment #204413 -
        Flags: review?(mconnor) → review+

    
    

    
  
viewSourceUtils.js v1.2 was checked in by timeless.

    
  
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Blocks: 172817

    
    

    
  
Fixed on the 1.8 branch in bug 172817.
Keywords: fixed1.8.1
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Firefox 2 alpha2
Version: Trunk → 2.0 Branch
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: