"Create" button for flags has many leading spaces

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
User Interface
--
trivial
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Mark Bickford, Assigned: Mark Bickford)

Tracking

unspecified
Bugzilla 2.20
Bug Flags:
approval +
approval2.20 +

Details

(URL)

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Fedora/1.0.7-1.1.fc4 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Fedora/1.0.7-1.1.fc4 Firefox/1.0.7

In template/en/default/admin/flag-type/edit.html.tmpl, there are 5 or more spaces at the end of a line (and one on another) that are included in the value parameter of the input type="button" tag.  This results in an ugly, right-justified button.  See attached screenshot for an example.  Applies to 2.18, 2.20 and tip.

Reproducible: Always

Steps to Reproduce:
1.  Go into a default install of Bugzilla to which you have permission to edit flags
2.  Choose "Flags" from the admin menu, then "Create Flag Type for Bugs"
3.  See extraneous spaces in button

Actual Results:  
Button contains unnecessary spaces

Expected Results:  
Button should have a Value parameter containing the desired text, trimmed of extra spaces.
(Assignee)

Comment 1

13 years ago
Created attachment 204507 [details]
Screenshot showing justification problem

This image shows the problem described in the bug.
(Assignee)

Comment 2

13 years ago
Created attachment 204508 [details] [diff] [review]
Patch for the 2.20 release

It's my first-ever patch submission, and I realize it's trivial, but I thought I'd offer it up.
Attachment #204508 - Flags: review?
(Assignee)

Updated

13 years ago
Attachment #204508 - Flags: review? → review?(myk)

Updated

13 years ago
Assignee: myk → markhb
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 3

13 years ago
Created attachment 204509 [details] [diff] [review]
Updated to use [%- directive

Changed to add [%- directives based on Karl's comments in IRC.
Attachment #204508 - Attachment is obsolete: true
Attachment #204509 - Flags: review?
Attachment #204508 - Flags: review?(myk)
(Assignee)

Comment 4

13 years ago
Comment on attachment 204509 [details] [diff] [review]
Updated to use [%- directive

Adding jouni as review requestee.
Attachment #204509 - Flags: review? → review?(jouni)
(Assignee)

Comment 5

13 years ago
Created attachment 204511 [details] [diff] [review]
Patch for the tip (2.21.1)

Adding patches for 2.18 and the tip.
Attachment #204511 - Flags: review?(jouni)
(Assignee)

Comment 6

13 years ago
Created attachment 204512 [details] [diff] [review]
Patch for the 2.18 branch
Attachment #204512 - Flags: review?(jouni)

Comment 7

13 years ago
Comment on attachment 204512 [details] [diff] [review]
Patch for the 2.18 branch

only security bugs and major bugs are accepted for 2.18.
Attachment #204512 - Flags: review?(jouni) → review-
Comment on attachment 204511 [details] [diff] [review]
Patch for the tip (2.21.1)

Yup, good patch. Thank you :)
Attachment #204511 - Flags: review?(jouni) → review+
Comment on attachment 204509 [details] [diff] [review]
Updated to use [%- directive

No need for a separate 2.20 branch patch. The patch for the tip applies to the 2.20 branch cleanly.
Attachment #204509 - Attachment is obsolete: true
Attachment #204509 - Flags: review?(jouni)
Comment on attachment 204512 [details] [diff] [review]
Patch for the 2.18 branch

Obsoleting attachment 204512 [details] [diff] [review] (seconding comment 7).
Attachment #204512 - Attachment is obsolete: true
Flags: approval?
Flags: approval2.20?
Target Milestone: --- → Bugzilla 2.20
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval2.20?
Flags: approval2.20+
Flags: approval+
Thanks, Mark!

Checking in template/en/default/admin/flag-type/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.13; previous revision: 1.12
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Oh yeah, branch too (thanks Frédéric):

Checking in template/en/default/admin/flag-type/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.11.4.1; previous revision: 1.11
done
You need to log in before you can comment on or make changes to this bug.