318225 - "Create" button for flags has many leading spaces

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Mark Bickford]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Fedora/1.0.7-1.1.fc4 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Fedora/1.0.7-1.1.fc4 Firefox/1.0.7

In template/en/default/admin/flag-type/edit.html.tmpl, there are 5 or more spaces at the end of a line (and one on another) that are included in the value parameter of the input type="button" tag.  This results in an ugly, right-justified button.  See attached screenshot for an example.  Applies to 2.18, 2.20 and tip.

Reproducible: Always

Steps to Reproduce:
1.  Go into a default install of Bugzilla to which you have permission to edit flags
2.  Choose "Flags" from the admin menu, then "Create Flag Type for Bugs"
3.  See extraneous spaces in button

Actual Results:  
Button contains unnecessary spaces

Expected Results:  
Button should have a Value parameter containing the desired text, trimmed of extra spaces.

Comment 1

[Mark Bickford]

Attachment: Screenshot showing justification problem

This image shows the problem described in the bug.

Comment 2

[Mark Bickford]

Attachment: Patch for the 2.20 release

It's my first-ever patch submission, and I realize it's trivial, but I thought I'd offer it up.

Comment 3

[Mark Bickford]

Attachment: Updated to use [%- directive

Changed to add [%- directives based on Karl's comments in IRC.

Comment 4

[Mark Bickford]

Comment on attachment 204509 [details] [diff] [review]
Updated to use [%- directive

Adding jouni as review requestee.

Comment 5

[Mark Bickford]

Attachment: Patch for the tip (2.21.1)

Adding patches for 2.18 and the tip.

Comment 6

[Mark Bickford]

Attachment: Patch for the 2.18 branch

Comment 7

[Frédéric Buclin]

Comment on attachment 204512 [details] [diff] [review]
Patch for the 2.18 branch

only security bugs and major bugs are accepted for 2.18.

Comment 8

[Marc Schumann [:Wurblzap]]

Comment on attachment 204511 [details] [diff] [review]
Patch for the tip (2.21.1)

Yup, good patch. Thank you :)

Comment 9

[Marc Schumann [:Wurblzap]]

Comment on attachment 204509 [details] [diff] [review]
Updated to use [%- directive

No need for a separate 2.20 branch patch. The patch for the tip applies to the 2.20 branch cleanly.

Comment 10

[Marc Schumann [:Wurblzap]]

Comment on attachment 204512 [details] [diff] [review]
Patch for the 2.18 branch

Obsoleting attachment 204512 [details] [diff] [review] (seconding comment 7).

Comment 11

[Marc Schumann [:Wurblzap]]

Thanks, Mark!

Checking in template/en/default/admin/flag-type/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.13; previous revision: 1.12
done

Comment 12

[Marc Schumann [:Wurblzap]]

Oh yeah, branch too (thanks Frédéric):

Checking in template/en/default/admin/flag-type/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.11.4.1; previous revision: 1.11
done