318380 - move snippets into lib/

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Snippets like src/firefox/featureheader.html--which aren't pages in their own right but may get inserted into multiple other pages--should be moved into lib/, which is designed for the purpose.  Doing this also prevents such snippets from becoming pages on the production site, since anything in src/ with a .html suffix is going to get pushed to production when the site gets built.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: moves files

This patch doesn't modify the files in any way, it just moves them into lib/.  Since lib/ is on the include search path, references to the files like [% INCLUDE frontfeature.html %] still work without modification.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: moves files and updates references

Erm, that last comment wasn't completely true.  Actually I do need to update references in INCLUDES, since they contain paths (i.e firefox/...) instead of just filenames.  Here's the change with those references updated.

Comment 3

[Steven Garrity [:sgarrity]]

Comment on attachment 204621 [details] [diff] [review]
patch v2: moves files and updates references

looks good

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Thanks Steve.

RCS file: /cvsroot/mozilla-com/lib/featureheader.html,v
done
Checking in lib/featureheader.html;
/cvsroot/mozilla-com/lib/featureheader.html,v  <--  featureheader.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla-com/lib/firefoxfeature.html,v
done
Checking in lib/firefoxfeature.html;
/cvsroot/mozilla-com/lib/firefoxfeature.html,v  <--  firefoxfeature.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla-com/lib/frontfeature.html,v
done
Checking in lib/frontfeature.html;
/cvsroot/mozilla-com/lib/frontfeature.html,v  <--  frontfeature.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla-com/lib/thunderbirdfeature.html,v
done
Checking in lib/thunderbirdfeature.html;
/cvsroot/mozilla-com/lib/thunderbirdfeature.html,v  <--  thunderbirdfeature.html
initial revision: 1.1
done
Removing src/frontfeature.html;
/cvsroot/mozilla-com/src/frontfeature.html,v  <--  frontfeature.html
new revision: delete; previous revision: 1.12
done
Removing src/firefox/featureheader.html;
/cvsroot/mozilla-com/src/firefox/featureheader.html,v  <--  featureheader.html
new revision: delete; previous revision: 1.2
done
Removing src/firefox/firefoxfeature.html;
/cvsroot/mozilla-com/src/firefox/firefoxfeature.html,v  <--  firefoxfeature.html
new revision: delete; previous revision: 1.5
done
Checking in src/firefox/index.html;
/cvsroot/mozilla-com/src/firefox/index.html,v  <--  index.html
new revision: 1.10; previous revision: 1.9
done
Checking in src/firefox/livebookmarks.html;
/cvsroot/mozilla-com/src/firefox/livebookmarks.html,v  <--  livebookmarks.html
new revision: 1.5; previous revision: 1.4
done
Checking in src/firefox/search.html;
/cvsroot/mozilla-com/src/firefox/search.html,v  <--  search.html
new revision: 1.5; previous revision: 1.4
done
Checking in src/firefox/tabs.html;
/cvsroot/mozilla-com/src/firefox/tabs.html,v  <--  tabs.html
new revision: 1.6; previous revision: 1.5
done
Checking in src/thunderbird/index.html;
/cvsroot/mozilla-com/src/thunderbird/index.html,v  <--  index.html
new revision: 1.6; previous revision: 1.5
done
Removing src/thunderbird/thunderbirdfeature.html;
/cvsroot/mozilla-com/src/thunderbird/thunderbirdfeature.html,v  <--  thunderbirdfeature.html
new revision: delete; previous revision: 1.3
done