Closed Bug 318402 Opened 19 years ago Closed 19 years ago

Rename JS_STRINGS_ARE_UTF8 to JS_C_STRINGS_ARE_UTF8

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: daumling, Unassigned)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

This patch does the requested replacement.
8.93 KB, patch
brendan
: review+
darin.moz
: approval1.8.1+
Details | Diff | Splinter Review
Brendan would like to rename JS_STRINGS_ARE_UTF8 to JS_C_STRINGS_ARE_UTF8 (or JS_CHAR_STRINGS_ARE_UTF8). I would submit a patch as soon as my other patchesd have been checked in.
Depends on: 215173, 315436, 315974
Status: NEW → ASSIGNED
Blocks: js1.6rc1
Flags: testcase-
This is a simple text-replacement patch. Is a sr necessary?
Attachment #212326 - Flags: review?(brendan)
Comment on attachment 212326 [details] [diff] [review] This patch does the requested replacement. rs=me (rs for "rubber stamp" ;-). Confirm: we are not yet turning on this macro by default. Mozilla code is not ready for it. /be
Attachment #212326 - Flags: review?(brendan) → review+
Patch has been checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Flags: blocking1.8.1?
Is this happening on the 1.8 branch as part of the JS 1.7 merging? Is it in JS 1.7?
This is in the trunk but not any 1.8 branches and is not part of Spidermonkey 1.7. It was supposed to be part of Spidermonkey 1.6 though but that is in limbo at the moment.
Flags: blocking1.8.1? → blocking1.8.1+
Attachment #212326 - Flags: approval1.8.1+
Flags: blocking1.8.1+ → blocking1.8.1-
Turns out this did land on the 1.8 branch with js1.7.
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: