Closed Bug 318423 Opened 17 years ago Closed 17 years ago

thebes/cairo-gtk2 toolkit doesn't work on 16-bit display

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sanctity.tawdriest.stephen, Assigned: sanctity.tawdriest.stephen)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20051130 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20051130 Firefox/1.6a1

Off-screen images are created with a 24-bit depth, and the result is that windows are not painted on a 16-bit display.

Reproducible: Always

Steps to Reproduce:
1. Build current trunk with --enable-default-toolkit=cairo-gtk2

2. Exceute Firefox on a 16-bit display
Actual Results:  
Window frames are drawn, but their contents are not drawn, so you see whatever window was drawn in that area on the screen by other applications.

Expected Results:  
It should have drawn properly.
Attachment #204602 - Flags: review?
Version: unspecified → Trunk
It would be appreciated if you could make this a CVS diff instead of just a diff of the source.
Component: General → GFX: Thebes
Flags: review?
Product: Firefox → Core
QA Contact: general → thebes
(In reply to comment #2)
> It would be appreciated if you could make this a CVS diff instead of just a
> diff of the source.

That is a CVS diff.

I'll get this checked in in the next day or so; I think there's another place where the bpp comes into play (plugins?).. need to make sure that we're consistent.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Sorry, didn't mean to remove your review request. You can just request it again on the CVS diff version (or again now until you get the CVS diff).

See http://developer.mozilla.org/en/docs/Mozilla_Source_Code_Via_CVS for information about CVS and exactly what to do.

If you have any questions or need assistance in this process, just ask.
Assignee: nobody → stephen
Attachment #204602 - Flags: review?(vladimir)
(In reply to comment #3)
> (In reply to comment #2)
> > It would be appreciated if you could make this a CVS diff instead of just a
> > diff of the source.
> 
> That is a CVS diff.

No, it is not a CVS diff. The attached patch was made by using the "diff" command and not "cvs diff". While this patch is simple enough to be dealt with without an actual CVS diff, it's a good habit to just submit patches as CVS diffs all the time. A CVS diff is much more helpful in finding the respective code and tracking changes in the code.
Status: NEW → ASSIGNED
(In reply to comment #5)
> No, it is not a CVS diff.

*sigh* Sorry... :P

It is a CVS diff but just without the RCS header that I'm so used to. My apologies to you greatly.

/me feels stupid :/
This was fixed by a Jan 19 check-in by vlad (gfxPlatformGtk.cpp 1.3):

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/gfx/thebes/src&command=DIFF_FRAMESET&file=gfxPlatformGtk.cpp&rev2=1.3&rev1=1.2
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.