318560 - replace javascript on Firefox Central to point to locally hosted searchplugins

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Replace the addEngines function on www.mozilla.com/firefox/central to point to the searchPlugins that are locally hosted on AMO. This is the new code that should be used.

function addEngine(name,ext,cat,type)
{
 if ((typeof window.sidebar == "object") && (typeof window.sidebar.addSearchEngine == "function")) { 
     window.sidebar.addSearchEngine(
       "http://addons.mozilla.org/search-engines-static/"+name+".src",
       "http://addons.mozilla.org/search-engines-static/"+name+"."+ext, name, cat );
 } else {
   errorMsg(name,ext,cat);
 } 
}

Comment 1

[Mycroft Project (CC)]

thanks Mike

Comment 2

[:Gavin Sharp [email: [e-mail]]]

*** Bug 318562 has been marked as a duplicate of this bug. ***

Comment 3

[victory <[e-mail]>]

don't change these?
http://mycroft.mozdev.org/judge.php?...
http://mycroft.mozdev.org/error.html
"http://mycroft.mozdev.org/plugins/"

Comment 4

[Mycroft Project (CC)]

function judgePopUp(id,type) can go entirely and

function errorMsg(name,ext,cat)
{
  alert("Netscape 6 or Mozilla is needed to install a sherlock plugin");
}
would be fine (though might be better updated ;) )

function addEngine(name,ext,cat,type) is correct in the opening comment

Comment 5

[Steven Garrity [:sgarrity]]

I've checked in the changes to addEngine() and removed judgePopUp()

Please test.

Comment 6

[Mycroft Project (CC)]

looks fine to me and installed all 4 satisfactorily
you could edit the errorMsg() function as described in comment #4 but I wouldn't worry about it too much.

Comment 7

[Peter van der Woude [:Peter6]]

*** Bug 259863 has been marked as a duplicate of this bug. ***