Closed
Bug 318616
Opened 19 years ago
Closed 19 years ago
module-static nsTestTagTable is bad
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
2.99 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
There is a module-static nsTestTagTable at http://lxr.mozilla.org/mozilla/source/parser/htmlparser/src/nsHTMLTags.cpp#495 which is bad because it calls XPCOM methods at theoretically bad times and therefore breaks the nsTraceRefCntImpl legal-activity checks, which I'm using to help get XPCOM shutdown in order. The patch will move the checks into the module-startup code which is a safe place to do this debug-only work.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #204728 -
Flags: review?(mrbkap)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 204728 [details] [diff] [review]
Move debug test into module initializer, rev. 1
Yes, please.
Attachment #204728 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•