module-static nsTestTagTable is bad

RESOLVED FIXED in mozilla1.9alpha1

Status

()

--
minor
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: benjamin, Assigned: benjamin)

Tracking

Trunk
mozilla1.9alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
There is a module-static nsTestTagTable at http://lxr.mozilla.org/mozilla/source/parser/htmlparser/src/nsHTMLTags.cpp#495 which is bad because it calls XPCOM methods at theoretically bad times and therefore breaks the nsTraceRefCntImpl legal-activity checks, which I'm using to help get XPCOM shutdown in order. The patch will move the checks into the module-startup code which is a safe place to do this debug-only work.
(Assignee)

Comment 1

13 years ago
Created attachment 204728 [details] [diff] [review]
Move debug test into module initializer, rev. 1
Attachment #204728 - Flags: review?(mrbkap)
(Assignee)

Updated

13 years ago
Blocks: 318622
Comment on attachment 204728 [details] [diff] [review]
Move debug test into module initializer, rev. 1

Yes, please.
Attachment #204728 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 3

13 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.