318823 - Places should not act like Web content (disable some menu items when Places is showing)

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Hixie (not reading bugmail)]

The following menu items and associated shortcut keys should be disabled when Places is being shown in the active tab:
  + File | Save As
  + File | Send Link
  + File | Print Preview (or make it usefully work)
  + File | Print (or make it usefully work)
  + Edit | Select All (or make it usefully work)
  + Edit | Find in This Page
  + "/" and "'" shortcuts for Find in This Page
  + Edit | Find Again
  + View | Status Bar (or don't hide it in the first place; qv. bug 318820.)
  + View | Reload
  + View | Text Size submenu items
  + View | Page Style submenu items
  + View | Character Encoding submenu items
  + View | Page Source
  + Bookmarks | Add Bookmark
  + Bookmarks | Show Places
  + Tools | Page Info

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Disable menu items when switching to places page. I'm going to make this bug be about disabling non-functional items, I'll have other bugs on making those that are still enabled work.

Comment 2

[Annie Sullivan]

Comment on attachment 205876 [details] [diff] [review]
patch


>+  _disableCommands: function PUIH__disableCommands() {
>+    var commands = ["Browser:SavePage", "Browser:SaveFrame", "Browser:SendLink", 
>+                    "cmd_pageSetup", "cmd_print", "cmd_printPreview", 
>+                    "cmd_findAgain", "cmd_switchTextDirection", "Browser:Stop",
>+                    "Browser:Reload", "viewTextZoomMenu", "pageStyleMenu", 
>+                    "charsetMenu", "View:PageSource", "View:FullScreen", 
>+                    "documentDirection-swap", "Browser:AddBookmarkAs", 
>+                    "Browser:ShowPlaces", "View:PageInfo", "cmd_toggleTaskbar"];
>+    for (var i = 0; i < commands.length; ++i)
>+      this._topWindow.document.getElementById(commands[i]).
>+        setAttribute("disabled", true);
>+  },
>+  
>+  /**
>+   * Enable commands that aren't updated automatically by the command updater
>+   * when we switch away from the Places page. 
>+   */
>+  _enableCommands: function PUIH__enableCommands() {
>+    var commands = ["Browser:SavePage", "Browser:SaveFrame", "Browser:SendLink", 
>+                    "cmd_pageSetup", "cmd_print", "cmd_printPreview", 
>+                    "cmd_findAgain", "cmd_switchTextDirection", "Browser:Stop",
>+                    "Browser:Reload", "viewTextZoomMenu", "pageStyleMenu", 
>+                    "charsetMenu", "View:PageSource", "View:FullScreen", 
>+                    "documentDirection-swap", "Browser:AddBookmarkAs", 
>+                    "Browser:ShowPlaces", "View:PageInfo", "cmd_toggleTaskbar"];
>+    for (var i = 0; i < commands.length; ++i)
>+      this._topWindow.document.getElementById(commands[i]).
>+        removeAttribute("disabled");
>+  },

Is there a reason not to make commands a member variable, so that if commands need to be added or removed, there's only one place to do that?

Otherwise, looks good.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Done. checked in. 

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv