Closed Bug 31892 Opened 24 years ago Closed 24 years ago

A crash occurs with onfocus event assigned to a AREA element

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Platform:
x86
Windows 98
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: chrispetersen, Assigned: joki)

References

(
URL
)

Details

(Keywords: crash, platform-parity, Whiteboard: [nsbeta2+]fix in hand) 

Build: Apprunner
Version: 2000031318
Platform: Win
Other Platforms: Works on Mac.Need to try on Linux.
Expected Results: A dialog should appears generated by the onFocus event.
What I Got: The application crashes.


Steps to reproduce: 

1) Open the following test case:

http://mozilla.org/quality/browser/standards/html/area_onfocus.html


2) Click on the red circle.


3) The application should crash.
Keywords: beta1
Okay, if we still want this for beta I have a fix.  Non-threatening null check.
Whiteboard: fix in hand
Please include a patch in the bug.
If I understand your comment, you have a one line null check.
Thanks,
Jim

Here is the patch.

Index: nsImageMap.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/base/src/nsImageMap.cpp,v
retrieving revision 3.38
diff -r3.38 nsImageMap.cpp
915c915
<         if (NS_FAILED(rv)) return PR_FALSE;
---
>         if (NS_FAILED(rv) || !baseUri) return PR_FALSE;
Status: NEW → ASSIGNED
Severity: normal → critical
Keywords: crash, pp
Summary: [pp]A crash occurs with onfocus event assigned to a AREA element → A crash occurs with onfocus event assigned to a AREA element
Putting on PDT- radar.  Does this impact any top 100?
Whiteboard: fix in hand → [PDT-]fix in hand
Jan,

This test case wasn't distilled from a site so I don't know. But since both AREA 
maps and JS alert dialogs are frequently used, this problem may occur on various 
site.

adding beta2 keyword, and removing pdt status
Keywords: beta2
Whiteboard: [PDT-]fix in hand → fix in hand
removing beta1 keyword so it doesn't show up on beta1 radar
Keywords: beta1
Moving to m16 due to severity
Target Milestone: --- → M16
Putting on [beta2+] radar....check it in!!!:-)
Whiteboard: fix in hand → [beta2+]fix in hand
Keywords: nsbeta2
Updating [beta2+] in Status Summary to [nsbeta2+]
Keywords: beta2
Whiteboard: [beta2+]fix in hand → [nsbeta2+]fix in hand
patch checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
With the May 15th build (2000051508), I can nolonger reproduce this crash under 
Win 98. Marking verified fixed.
Status: RESOLVED → VERIFIED
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.