Closed
Bug 318964
Opened 20 years ago
Closed 20 years ago
implement HMAC algorithm tests for FIPS 140-2 validation
Categories
(NSS :: Test, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.11.1
People
(Reporter: glenbeasley, Assigned: glenbeasley)
Details
Attachments
(1 file)
|
7.74 KB,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
| Assignee | ||
Comment 1•20 years ago
|
||
| Assignee | ||
Comment 2•20 years ago
|
||
Attachment #206047 -
Flags: review?(wtchang)
Comment 3•20 years ago
|
||
Comment on attachment 206047 [details] [diff] [review]
Added FIPS 140-2 HMAC test
>+ /* set the HASH algorithm for HMAC */
>+ if (HMACLen == SHA1_LENGTH) {
>+ hash_alg = HASH_AlgSHA1;
>+ } else if (HMACLen == SHA256_LENGTH) {
>+ hash_alg = HASH_AlgSHA256;
>+ } else if (HMACLen == SHA384_LENGTH) {
>+ hash_alg = HASH_AlgSHA384;
>+ } else if (HMACLen == SHA512_LENGTH) {
>+ hash_alg = HASH_AlgSHA512;
>+ }
Should add an "else" block that "goto loser".
r=wtc.
Attachment #206047 -
Flags: review?(wtchang) → review+
Comment 4•20 years ago
|
||
Glen, please check in your FIPS algorithm tests on
both the trunk and the NSS_11_BRANCH. We will be
running the algorithm tests using a NSS_3_11_BRANCH
build.
| Assignee | ||
Comment 5•20 years ago
|
||
Checking in fipstest.c;
/cvsroot/mozilla/security/nss/cmd/fipstest/fipstest.c,v <-- fipstest.c
new revision: 1.7; previous revision: 1.6
done
RCS file: /cvsroot/mozilla/security/nss/cmd/fipstest/hmac.sh,v
done
Checking in hmac.sh;
/cvsroot/mozilla/security/nss/cmd/fipstest/hmac.sh,v <-- hmac.sh
initial revision: 1.1
done
| Assignee | ||
Updated•20 years ago
|
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•