Closed Bug 31912 Opened 25 years ago Closed 23 years ago

Leaking mEnv_HandlePool

Categories

(MailNews Core :: Database, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
Future

People

(Reporter: beard, Assigned: Bienvenu)

References

()

Details

(Keywords: memory-leak)

Attachments

(1 file)

Leak detector indicates that morkEnv::mEnv_HandlePool is leaking. The URL above 
shows the point of allocation that leaks.
these are mine now, I guess.
Assignee: davidmc → bienvenu
Marking M16 (not M15 stopper)
Target Milestone: --- → M16
accepting
Status: NEW → ASSIGNED
Not M16 stopper.  Marking M17.
Target Milestone: M16 → M17
moving to future.
Target Milestone: M17 → Future
Can we afford for this to remain futured?  If nothing else, apart from the 
mail/news usage, mork does get used in global history, impacting the rest of the 
product.
Keywords: mail1
changing priorities
Priority: P3 → P2
David,

How big of a leak is this? Will the whole db or folder get leaked because of this?
it's a very small leak.
marking nsbeta1- due to the fact that it's a small leak.
Keywords: nsbeta1-
Attached patch fix v1Splinter Review
I'll let bienvenu do the review on this, since it is mork.  (I'll do the sr=)

the patch seems ok to me.  hwaara, how did you test it?
I compiled with the change and then ran mailnews for a good while. I didn't
really know how to test, but I deleted and moved lots of mails...

bienvenu?
No, I'm not sure this is right. mEnvHandles come from a pool, and are returned
to the pool when CloseEnv is called. So just out and out deleting them is not
the way this was designed to work, as far as I can tell.
So why is this bug filed in the first place if it ain't leaking?

If it is leaking, then do you have any suggestions on approaches to fix this?
I meant that your fix was wrong, not that there wasn't a leak. It is, however, a
tiny, tiny, leak. We have bigger fish to fry.

For one thing, CloseEnv sets mEnv_HandlePool to null, so your fix will not do
anything - mEnv_HandlePool will always be null by the time the environment
destructor gets called.

If I knew what the correct fix was, I would fix it. This is *not* code that I
wrote; the person who wrote this code is long gone. So it requires
investigation. Sorry I can't be more helpful.
Bienvenu, isn't it as easy as replacing the set-to-null code with a nullcheck
and then delete?
no, we pool the handles. This means we allocate them from a pool, and return
them to a pool when done. At least, that's the idea.
then I guess this bug will have to wait some more for a fix :(
Blocks: 92580
QA Contact: lchiang → stephend
No longer blocks: 92580
Summary: [MLK] Leaking mEnv_HandlePool → Leaking mEnv_HandlePool
plussing; will be fixed when mork changes land.
Keywords: nsbeta1+
should be fixed now.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
After David's big checkin, I no longer see this when launching mail, reading an 
IMAP message, loading a folder or deleting messages.

Verified FIXED, using Purify.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: