31921 - Cannot resize windows larger than physical screen

Status: VERIFIED DUPLICATE of bug 56021

(Core :: XUL, defect, P3)

Description

[Tomas Ögren]

With the current builds on X, the content area will not fill the entire window
if it's larger than the physical screen. It will stay at screen size no matter
how large I make the window.

Comment 1

[Peter Trudelle]

reassigning to pavlov as p5 for m20

Comment 2

[Peter Trudelle]

Mass move of all M20 bugs to M30.

Comment 3

[Peter Trudelle]

Mass move of M20 bugs to M30

Comment 4

[Peter Trudelle]

Mass-moving all M20-M30 XPToolkit bugs to Future

Comment 5

[tor]

Easy to fix, though it reverses part of a change made by saari.  Adding
saari to the CC for comment as to why we should be locking the max size
of the content area to the screensize (especially since the toplevel
resizes as requested, leaving a rather odd looking browser).

Index: nsWindow.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/gtk/nsWindow.cpp,v
retrieving revision 1.284
diff -u -r1.284 nsWindow.cpp
--- nsWindow.cpp        2000/07/13 11:48:28     1.284
+++ nsWindow.cpp        2000/07/13 21:14:41
@@ -2611,15 +2611,6 @@
          aWidth, aHeight);
 #endif
   
-  PRInt32 screenWidth = gdk_screen_width();
-  PRInt32 screenHeight = gdk_screen_height();
-    
-  if(aWidth > screenWidth)
-    aWidth = screenWidth;
-    
-  if(aHeight > screenHeight)
-    aHeight = screenHeight;
-
   mBounds.width  = aWidth;
   mBounds.height = aHeight;

Comment 6

[saari (gone)]

Did this change get checked in? Is this why some windows are appearing offscreen 
again on my multiple monitor mac with different resolution  screens, with one in 
the negative coordinate space?

Yes, this check is in the wrong place, but you can't just remove it without 
moving the safety check higher up in to the window loading sequence.

Comment 7

[Tomas Ögren]

Nope. Not checked in.. Windows still can't be larger than the screen.

Comment 8

[timeless]

http://lxr.mozilla.org/seamonkey/source/widget/src/gtk/nsWindow.cpp#2614
This code affects all os's/platforms.
Saari did you ever find out what was causing "some windows are appearing 
offscreen again on my multiple monitor mac with different resolution  screens, 
with one in the negative coordinate space?" If so could you possibly mark that 
as blocking this, or somehow note that it is related?
My understanding of X and Win32 their window manangers are able to recover lost 
windows (as long as they have tangible sizes [win32 doesn't like 0x0 windows]) 
could the code mentioned be tagged XP_MAC? Helpwanted per Future. Need Info 
because unless someone can justify that code fragment for all/all i'd be 
interested in making it mac only.

Comment 9

[tor]

The code in widget/src/gtk only effects unix platforms (thus the
"gtk" bit).  Changing OS/platform to Linux/PC.

Comment 10

[timeless]

hrm, then /why/ was macos mentioned by saari? If this is only for gtk then I 
don't see any justification for not removing that code fragment.  Am I dead 
wrong?

Comment 11

[saari (gone)]

Similar code exists on other platforms. You need to make sure that the window
doesn't appear off-screen or larger than the screen when it is built/restored.
HOWEVER, that check needs to be higher up in the window building process than in
widget. 

Comment 12

[Stuart Parmenter]

unfuturing.  I get too many bugs related to this.  this needs to be fixed.

Comment 13

[Peter Trudelle]

nsbeta3-, not worth the time/risk for ns6

Comment 14

[tor]

*** This bug has been marked as a duplicate of 56021 ***

Comment 15

[John Morrison]

Okey-dokey.