Closed Bug 319217 Opened 19 years ago Closed 18 years ago

disable-crypto build break

Categories

(Firefox Build System :: General, defect)

x86
Windows CE
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 227792

People

(Reporter: aaronr, Assigned: benjamin)

Details

Attachments

(1 file)

I am building Minimo for Windows CE and ran into a problem where --disable-crypto doesn't work properly.  It it stopping nsIPK11TokenDB.idl from getting processed, but toolkit/components/passwordmgr/base/nsPasswordManager.cpp needs the nsIPK11TokenDB.h file.  So my build is breaking trying to link passwordmgr_s.lib since nsPasswordManager.obj isn't generated.
Assignee: dveditz → nobody
Component: Security → Build Config
QA Contact: toolkit → build-config
(Moving to Product Firefox which has a Password Manager component, even if the code is shared and lives in Toolkit)

This crypto dependency was added during the fix for bug 217409. Looks like crypto is simply a required/assumed part of the Firefox product. I'd be surprised if Minimo would be all that useful without SSL support, either.

If --disable-crypto is still supported then we need to add ifdefs, or the database initialization call could be moved to a javascript component which is run-time checked rather than compile-time.
Assignee: nobody → bryner
Product: Toolkit → Firefox
(In reply to comment #1)
> (Moving to Product Firefox which has a Password Manager component, even if the
> code is shared and lives in Toolkit)
> 
> This crypto dependency was added during the fix for bug 217409. Looks like
> crypto is simply a required/assumed part of the Firefox product. I'd be
> surprised if Minimo would be all that useful without SSL support, either.
> 
> If --disable-crypto is still supported then we need to add ifdefs, or the
> database initialization call could be moved to a javascript component which is
> run-time checked rather than compile-time.
> 

Just so that you know where I'm coming from, I'm using --disable-crypto trying to save some space in the .exe.  When I build debug with default settings, I'm running out of address space and the .exe won't run.  So I'm trying to remove anything sizable that I really don't need just so that I can debug my problem.
Hello,

I stumbled about the same error today when trying to build Mozilla Sunbird with --disable-crypto on Windows XP.

If I remove this option I get the error "configure: error: Building crypto support requires a valid version of the standalone assembler (ml.exe for MSVC)."

Is there a workaround or any chance to get this fixed in toolkit?
Same here with FF 1.5.0.1 on Solaris 8/Sparc
QA Contact: build-config → build.config
Assignee: bryner → nobody
resolved DONTCARE
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WONTFIX
We should at least short-circuit this at configure time if we aren't going to support building firefox without crypto.  I'd say just rip out the option completely but tb, sb & sm probably still support building without crypto.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
I'm trying to remove options from our support matrix, and this seems like a good candidate in any case.
Assignee: nobody → benjamin
Status: REOPENED → ASSIGNED
Attachment #227369 - Flags: review?(cls)
What about France?  (I'm only being partially facetious here. ;-))  IIRC, there are certain situations which call for no crypto in gecko.  The Firefox front end mandates it but do the other m.o apps?  Does m.o still require that we be able to build (gecko, at least) without crypto?
Given the number of things that get simpler if you don't have crypto involved, even in the year 2006, it seems like we (unfortunately) probably want to preserve this option. :(
Attachment #227369 - Flags: review?(cls)

*** This bug has been marked as a duplicate of 227792 ***
Status: ASSIGNED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → DUPLICATE
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: