319222 - Toolbar Customization broken, No new toolbars.

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Robert Claypool]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051128 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051128 Firefox/1.6a1

No new toolbars can be created. Attempting to create a new toolbar causes the refresh throbber in the menubar to move next to the Help Menu



Reproducible: Always

Steps to Reproduce:
1.Right click on a toolbar and choose Customize...
2. Click on Add new toolbar.
3. Type in 'General' or 'Test'
4. No perceptible new toolbar is created.
5. If at this point the same name is typed again, it will say that such a toolbar already exists.
6. Close Options Dialog Box
6a. I think at this point the refresh throbber moves next to the help menu from the right side of the menubar.
7. Go to View|Toolbars The new toolbar will not be listed.
8.Right click on a toolbar and choose Customize... agian
9. Click on Add new toolbar.
10. Type in 'General' or 'Test' again.
11. This time it will accept it again.
12. still no toolbar


Actual Results:  
No new toolbar. Throbber moved.

Expected Results:  
Created a new toolbar. Throbber stays put.

Comment 1

[Ria Klaassen (not reading all bugmail)]

The newly created toolbar has apparently the wrong minimum width. 
This is a regression between 1.9a1_2005100612 and 1.9a1_2005100619.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-10-06+11%3A00%3A00&maxdate=2005-10-06+19%3A00%3A00&cvsroot=%2Fcvsroot

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I can confirm the lack of any new toolbar, but for me, the throbber stays put in its usual spot (upper right corner).

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051210 Firefox/1.6a1

Comment 3

[Ria Klaassen (not reading all bugmail)]

No, there's nothing wrong with the throbber (when I don't drag the flexible space back in the Customize window). Sorry, forgotten to test the throbber :)

Comment 4

[Robert Claypool]

(In reply to comment #3)
> No, there's nothing wrong with the throbber (when I don't drag the flexible
> space back in the Customize window). Sorry, forgotten to test the throbber :)
> 
Yeah, I discovered that I must have accidentally removed the flexible space trying to figure out what was going on with the lack of new toolbar.

Comment 5

[Jon Henry]

I believe this is a dupe of bug 265798 or vice-versa. I have a patch in that bug that needs work, and I don't have time to fix it.

Comment 6

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #1)
> The newly created toolbar has apparently the wrong minimum width. 

Oh well, its not width but height.

Comment 7

[Ria Klaassen (not reading all bugmail)]

I compared the toolbar.css of a before-the-bug and after-the-bug build and the min-height seems to be forgotten.

Comment 8

[Steve England [:stevee]]

*** Bug 325968 has been marked as a duplicate of this bug. ***

Comment 9

[James Ross]

The fix as described in this bug (min-height) has landed as part of bug 313388.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/themes/winstripe/global/toolbar.css&rev=1.12#55

If this has not fixed this bug fully, please reopen with details.