319380 - canvas quadraticCurveTo implementation is incorrect/bogus

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The implementation of canvas's quadraticCurveTo is bogus; I have a simple fix (will attach in the next day or two, as I need to redo it for the 1.8 branch).

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: 319380-broken-canvas-quadraticCurveTo.patch

Patch.  Convert the quadratic curve to a cubic curve correctly.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 207520 [details] [diff] [review]
319380-broken-canvas-quadraticCurveTo.patch

r=stuart, over my shoulder since his machine is "printing".

This is really low risk, and fixes the quadraticCurveTo function.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in on trunk.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 207520 [details] [diff] [review]
319380-broken-canvas-quadraticCurveTo.patch

(Forgot to request approval flags)

Low-risk patch that fixes the canvas quadraticCurveTo function; just adds some math bits before calling in to cairo.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 207520 [details] [diff] [review]
319380-broken-canvas-quadraticCurveTo.patch

a=dveditz for drivers

Comment 6

[Marcia Knous [:marcia]]

Vlad: Is there any easy way for QA to verify this bug?