319443 - Firefox installer writes incorrect GeckoVer value to registry

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

After Gecko 1.8 branched from the trunk, GREVersion was never updated in installer.cfg from 1.7.5 to 1.8 to reflect the version change. It should be noted that installer.cfg on the trunk has been updated to 1.9a like it should be.

I'll submit a patch for this in a bit.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: 1.8.0.x Branch patch

Update GeckoVer value to 1.8.0 on 1.8.0.x branch

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: 1.8.1 Branch patch

Update GREVersion value to 1.8.1 on 1.8.1 branch

Comment 3

[Robert Strong (they/them - no direct email)]

Ryan, that is for the xpinstall based installer and is not used by the NSIS installer. The xpinstall based installer also wrote these values to the Software\Mozilla\AppName AppVer\GeckoVer and Software\Mozilla\AppName\(Default) keys and the NSIS installer writes the correct version in these two registry locations. I asked dveditz specifically about the Software\Mozilla\CurrentVersion key which the xpinstall based installer writes to and was told that apps shouldn't be writing to this location which the NSIS installer does not.

cc'ing dveditz to verify that my take on this is correct.

Comment 4

[Robert Strong (they/them - no direct email)]

Benjamin, could you take a look at my comment #3 to see if my take on this is valid? Thanks.

Comment 5

[Benjamin Smedberg]

This is fixed by the NSIS installer on 1.8 and trunk.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 226739 [details] [diff] [review]
1.8.0.x Branch patch

Ryan, I really don't know the xpinstall based installer well enough to review the patch for 1.8.0.x or to make the call whether it should be removed from the xpinstall based installer so I am clearing the review.

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 226740 [details] [diff] [review]
1.8.1 Branch patch

This is already fixed with the NSIS installer as so clearing the review and obsoleting