319480 - deleting a flagtype should ignore inactive flags when confirming

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Albert Ting]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

When change a flag from "+" to a blank, the mysql database does not get updated accordingly.  However, I do see the Bug Activity page get updated. 

This is with 2.20+

Reproducible: Always

Steps to Reproduce:

Comment 1

[Albert Ting]

Clarification, I see that the "is_active" flag is turned off when you clear a flag.  However, how would one normally search for these "inactive" flags? 

I'm trying to remove old flags but it warns me that it is being used.  Looking further, it appears all the used ones were marked "inactive".

Comment 2

[Frédéric Buclin]

A flag is never removed from the DB, and removing a flag from the UI sets the is_active bit to off.

Comment 3

[Albert Ting]

(In reply to comment #2)
> A flag is never removed from the DB, and removing a flag from the UI sets the
> is_active bit to off.
> 

LpSolit.  I can understand that except for one key issue.  If I want to completely remove the flagtype, it complains that I am "using" the flag even though I can see all those bugs have that flag marked as is_active=0.  

Actually, I don't know of any way to list those inactive flags other than scanning the mysql database.

So in my opinion, completely deleting a flagtype should ignore all associated inactive flags, and then delete those inactive flags.

Comment 4

[Frédéric Buclin]

This will be fixed by bug 322285

Comment 5

[Frédéric Buclin]

Inactive flags no longer remain in the DB => FIXED!