319559 - Dragging and dropping a bookmark folder onto content opens new tabs

Status: VERIFIED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Stuart Morgan]

Sometime in the not to distant past, dropping a bookmark folder onto the content region started opening in new tabs, instead of replacing the current page. Was the change deliberate? It makes the behavior of dragging a folder (open in new tabs) and dragging a single bookmark (open in current tab) inconsistant, and appears to make it impossible to replace the content with a folder since the only context menu option is to open in new tabs.

Comment 1

[Chris Lawson (gone)]

This one's my fault, but I think it's because I erred on the side of caution when I fixed bug 311110.

What behaviour *should* we do when dragging a folder onto an extant tab? Replace that tab and append?

I think replacing current tabs other than the drag target (which is what we used to do) is a Bad Thing(tm) as it can cause data loss (or at minimum, frustration).

cl

Comment 2

[Chris Lawson (gone)]

Never mind, it's not a sticky situation at all.

Taking. I'll try to get this fixed ASAP. Should be a simple matter of looking at drags ending in a content area in addition to tabs.

Smokey's filing a new bug on the fact that cmd-drag doesn't force append.

cl

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bug 319627

Comment 4

[Chris Lawson (gone)]

Attachment: one-line fix to check for overContentArea too

Oops. At least the fix was easy. :)

cl

Comment 5

[Julian Pellico]

Comment on attachment 205368 [details] [diff] [review]
one-line fix to check for overContentArea too

Works as advertised

Comment 6

[Simon Fraser [no longer active]]

Checked in.

Comment 7

[Samuel Sidler (old account; do not CC)]

v on branch and trunk.