Closed Bug 319582 Opened 14 years ago Closed 14 years ago

Update from 1.5rc2 hangs in update download on 9k file

Categories

(Toolkit :: Application Update, defect, blocker)

1.8.0 Branch
PowerPC
macOS
defect
Not set
blocker

Tracking

()

VERIFIED FIXED

People

(Reporter: tracy, Assigned: morgamic)

Details

(Keywords: regression)

Attachments

(1 file)

Second round of locale testing turned up 1.5rc2 on Mac failing to complete the download of a 9k file (partial and full).  mscott mentioned in irc that we seem to be getting redirected to mozilla.org in the download.  

This worked in round one and doesn't affect Windows or Linux in round two.
Mike, this is an odd problem.  My understanding of how our bouncer 1 installation works is that if the en-US files are present, then bouncer will serve up any locale (since locales are a quick and dirty search and replace in the incoming download URL).

That the following two URLs fail...

 http://download.mozilla.org/?product=firefox-1.5-partial-1.5rc2&os=osx&lang=da
 http://download.mozilla.org/?product=firefox-1.5-complete&os=osx&lang=da

is better taken as an indication that the following two URLs will fail:

  http://download.mozilla.org/?product=firefox-1.5-partial-1.5rc2&os=osx&lang=en-US
 http://download.mozilla.org/?product=firefox-1.5-complete&os=osx&lang=en-US

When I investigated directly the file paths for these products in bouncer, they appeared to work fine.  At least one of our mirrors (mozilla.osuosl.org) has these files, too.

Can you take a look here and find out why sentry is failing to find the en-US files?  Thanks.
Assignee: chase → morgamic
Status: NEW → ASSIGNED
I am sure it's the mime-type checking in Sentry 1.  It needs to be modified so it will only do the .dmg mime-type check on files that end with ".dmg" instead of making the assumption that all OSX files are .dmg files.

I am testing this on a dev server first before throwing it on gecko.
This should fix the .dmg mime-type assumption that is messing up .mar files.
Attachment #205435 - Flags: review?(chase)
Comment on attachment 205435 [details] [diff] [review]
Adjustment to mime-type checking based on extension.

>-			if ( $res->{_headers}->{'content-type'} !~ /application\/octet-stream/ &&
>-                    $res->{_headers}->{'content-type'} !~ /application\/x-apple-diskimage/ ) {
>+			if ( $location->{location_path} =~ m/.*\.dmg$/ && $res->{_headers}->{'content-type'} !~ /application\/x-apple-diskimage/ ) {

Did you mean to remove the code that would avoid this mirror if the type returned for a dmg file is application/octet-stream?  application/octet-stream should be a satisfactory return type, from what I understand.
Yes, that was intentional.  See bug 318199.
Comment on attachment 205435 [details] [diff] [review]
Adjustment to mime-type checking based on extension.

r=chase
Attachment #205435 - Flags: review?(chase) → review+
This was pushed.  Sentry was also re-run and valid .mar files for OSX are now being enabled.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Thanks Mike!
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.