319681 - Cannot delete location/description of event

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[mozilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

When an event has a value for the "location" field, it can be changed to a different value, but not deleted.

Reproducible: Always

Steps to Reproduce:
1. Create an event with any value for "location", or add a location to an existing event.
2. Edit the event and delete the location.  Press OK.


Actual Results:  
The original value for the location remains.

Expected Results:  
The location should have been deleted.

in Sunbird 0.3a1

Comment 1

[Stefan Sitter [:ssitter]]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051208 Mozilla Sunbird/0.3a1+.

It is not possible to delete the value of the location and description field for events and tasks. No errors in javascript console.

Comment 2

[Stefan Sitter [:ssitter]]

Also confirmed with Gecko/20051208 Mozilla Thunderbird/1.6a1 + Lightning.
It is not possible to delete the content of the location/url/attendees/description field. (It is possible to delete the content of the title field as in sunbird)

Comment 3

[Joey Minta]

-> me

Comment 4

[Joey Minta]

Attachment: sunbird patch

Deletes the property if there isn't any value specified.  The idl states that this is acceptable to do, even if the property wasn't set before, and testing confirms this.

calendar-event-dialog.js does this in a much nicer way, with helper functions, etc.  We really do need to look into moving to that for Sunbird.

The lightning manifestation of this problem is the result of a failure to add an observer to the composite.  The fix for this is included in the new-views patch, and hence will not be included here.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 205445 [details] [diff] [review]
sunbird patch

r=mvl

Comment 6

[Joey Minta]

sunbird patch checked in.  Adding dependency on the new-views, since that ought to fix things in lightning.

Comment 7

[Stefan Sitter [:ssitter]]

Changing resolution to FIXED as it now also works with Lightning.
Tested successfully in Thunderbird 1.6a1 + Lightning (20060108).