If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Disallow development DBD versions

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Installation & Upgrading
P2
major
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

2.20
Bugzilla 3.0

Details

(Whiteboard: fixed by blocker)

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
We have a *lot* of people run into trouble because they try to install Bugzilla using a development DBD::mysql or DBD::Pg. You can always tell a development version because it has an underscore and then a number at the end.

We just need to die, if we hit a DBD::mysql or DBD::Pg like that.
(Assignee)

Comment 1

12 years ago
Created attachment 205393 [details] [diff] [review]
Disallow DBD versions with underscores

OK, this should work. I haven't been able to test it, since I don't have a development DBD installed anywhere handy. However, I have tested that it doesn't break normal installs at all.
Attachment #205393 - Flags: review?(wurblzap)
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Priority: -- → P2

Comment 2

12 years ago
Comment on attachment 205393 [details] [diff] [review]
Disallow DBD versions with underscores

>+    if ($vok and $pkg =~ /^DBD/ and $vnum =~ /_/) {
>+        print " $vstr\n"
>+              . "   $pkg $vstr is a development version, which Bugzilla"
>+              . " does not support.\n   Downgrade to a version without"
>+              . " an underscore (_) in the version number.";
>+        return !$vok;
>+    }

My opinion is that we should warn the user, but not stop checksetup.pl from running. I would remove "return !$vok;" and keep the warning only.

I'm not going to deny review, but it has not my vote.

Comment 3

12 years ago
(In reply to comment #2)
> My opinion is that we should warn the user, but not stop checksetup.pl from
> running.

My suggestion would be to add the --force option to ./checksetup.pl to force him to omit this test, for those users who really want to use their dev. DBD despite the warning.
Attachment #205393 - Flags: review?(wurblzap) → review?
I'm with Frédéric -- disallowing development DBDs could potentially break working installs all of a sudden. I'd call the parameter something less generic, though, for example --allow-development-dbd or something along these lines.
(Assignee)

Comment 5

12 years ago
I've never seen a development DBD with a working Bugzilla, but I'll add the parameter.

Comment 6

12 years ago
Comment on attachment 205393 [details] [diff] [review]
Disallow DBD versions with underscores

per previous comments
Attachment #205393 - Flags: review? → review-

Comment 7

11 years ago
2.20 and 2.22 have been released. Let's leave them alone.
Target Milestone: Bugzilla 2.20 → Bugzilla 2.24
(Assignee)

Comment 8

11 years ago
Fixed in bug 360710.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: fixed by blocker
You need to log in before you can comment on or make changes to this bug.