Closed Bug 319857 Opened 14 years ago Closed 11 years ago

Crash with Flash plugin context menus while loading a new page

Categories

(Firefox :: Menus, defect, critical)

1.5.0.x Branch
defect
Not set
critical

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: thecoreh, Unassigned)

References

()

Details

(Keywords: crash, stackwanted)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8) Gecko/20051111 Firefox/1.5

If there's a Flash plugin context menu opened, and the current page changes, the context menu will still be shown on the new page, and then the browser will crash.


Reproducible: Always

Steps to Reproduce:
1. Click a link on a flash menu
2. While the next page isn't beeing shown yet, right click this flash menu, to bring the context menu
3. Wait for the new page to load.

Actual Results:  
The context menu wil be still there, and the browser will crash after a while, or when you click outside the menu to close it.

Expected Results:  
The context menu should disappear before displaying the new page.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 ID:2005111116

I get this too. TB12846261G
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: crash
OK i don't get the crash with Shockwave Flash 7.0 r61 but I do with 8.0 r22
Keywords: stackwanted
Looks like a crash in the Flash player, not Firefox.
(In reply to comment #3)
> Looks like a crash in the Flash player, not Firefox.
> 

If it was a crash on the player, IE would crash on the same way... I think Firefox must somehow deactivate all the plugin menus before moving to another page.
(In reply to comment #4)
> If it was a crash on the player, IE would crash on the same way

The flash plugin for IE is not the same as the flash plugin for Firefox.
I can some more general and specific info on this bug. First, more generally, you don't have to navigate away from the page by clicking on a flash menu, you can do it with any HTML <a> link, then (quickly) right click a flash object.

Specific info:
Flash version: "Shockwave Flash 8.0 r22" from (about:plugins)
FF Build ID:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 - Build ID: 2005111116
I reproduce this bug with both Flash Player 7 and Flash Player 8.

In my debugging, I see the crash is not in the Flash Player but in ntdll.dll.

These bugs seem related: bug 168065 and bug 183586.

Comment 3 says this seems like a Flash Player crash. Why do you think that?
Michelle, what's the stack look like?
blaming ntdll is usually unreasonable. that said, i'm starting to get nice support from the microsoft newsgroups. what does windbg !analyze -v say for your crash? (you have the advantage of having symbols for flash, although neither of us have symbols for firefox, you could use mcsmurf's firefox + symbol server - see developer.mozilla.org, or build your own).
OS: Windows XP → All
Hardware: PC → All
Version: unspecified → 1.5 Branch
Some further information from the Flash side. On Windows, the plug-in calls TrackPopupMenu, a synchronous function (http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winui/windowsuserinterface/resources/menus/menureference/menufunctions/trackpopupmenu.asp).

While Flash is waiting for TrackPopupMenu to return, on a separate thread the browser eventually calls NPP_Shutdown.

After this, TrackPopupMenu returns. Crash.

I believe the Netscape sample plug-in npavi also uses TrackPopupMenu, so this problem shouldn't be limited to Flash.
But it's possible for FX to know if this function has been called before calling NPP_Shutdown?

Or maybe, even if it's not possible to know that, if it hasn't been called FX can return a value for it? (Will this make it crash, too?)
I think this bug can be generalised to crashing whenever a page changes with the flash context menu open because I had the same problem when I right clicked on a flash animation and then used a back button to go back one page in my history. Once I clicked on the window of the new page which had opened (closing the flash context menu) firefox crashed
*** Bug 339141 has been marked as a duplicate of this bug. ***
afaik our samples never create their own threads, i presume you're calling track menu on some other thread, because afaik if we call the plugin shutdown on a thread other than the main one, that'd be a big bug on our side.
I don't repro this crash on Windows Firefox 1.5.0.4 with the recent Flash Player 9 release (Flash Player 9r16).
*** Bug 333699 has been marked as a duplicate of this bug. ***
I have an example here which triggers the crash, in case that's needed:
http://wargers.org/mozilla/bug333699/333699_flash_context_crash.html
It seems to me that bug 183586 is related, not?
Thank you, Martijn. I repro on Win Firefox 1.5 with Flash Player 9r16.
(In reply to comment #17)
> I have an example here which triggers the crash, in case that's needed:
> http://wargers.org/mozilla/bug333699/333699_flash_context_crash.html
> It seems to me that bug 183586 is related, not?
> 
FYI, I'm using SeaMonkey 1.5a and Flash 9.0 r16. If I go to the above page and right click on the Flash object, the redirection does not occur until the Flash context menu is dismissed. Don't know whether this is a feature of Flash 9 or SeaMonkey.

If comment #19 refers to SeaMonkey on Windows, I think the fact there is no crash must be due to SeaMonkey code, not Flash 9. (The Flash Player plug-in code is the same for Win Firefox and Win SeaMonkey.)
Ok, it seems that this was fixed on trunk between 2006-05-09 and 2006-05-10, this is the time when the threadmanager patch landed.
Depends on: nsIThreadManager
Martijn in comment #21
> Ok, it seems that this was fixed on trunk between 2006-05-09 and 2006-05-10,
> this is the time when the threadmanager patch landed.

fixed for MAC or for Windows, or both?
 

Michelle comment #7
> I reproduce this bug with both Flash Player 7 and Flash Player 8.
> 
> In my debugging, I see the crash is not in the Flash Player but in ntdll.dll.
> 
> These bugs seem related: bug 168065 and bug 183586.

if this bug is fixed, are either or both also gone/fixed or still related?

you might read bug 183586 comment 29 - it sounds odd to me.
Not fixed in Windows.  Using XP Pro Build 2600.xpsp_sp2z-gdr.070227-2254(Service Pack 2).  

Here are examples:

http://www.mgoblue.com/home/  --> FX asks for plugins to be installed via the dropdown.  Then, when clicking to install plugins, FX gives error:  "No matching plugins were found".  

Here's another:
http://www.cnn.com/video/#/video/politics/2008/09/11/kaye.palin.honest.cnn  

Flash just doesn't load, gallery doesn't work.  

FYI, both of these work perfectly in IE7 and Google Chrome.  Here is my flash version:
9,0,124,0 installed

Firefox version:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
(In reply to comment #23)

Dan, are you talking about the same bug as this one? This bug is about a crash. You are talking about web content not loading and not crashing, right?

By the way, Flash Player 10 has been released: http://www.adobe.com/go/getflashplayer
Dan seems to be gone, and he was the only one left seeing this.
=> incomplete
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.