319997 - Convert parser tests to use the frozen symbol API

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement)

Description

[Benjamin Smedberg]

libxul is going to stop exporting the non-frozen XPCOM symbols, and it is therefore necessary for various tests/utils to use the frozen linkage APIs. This bug is for parser/htmlparser/tests

Comment 1

[Benjamin Smedberg]

Attachment: parser/htmlparser/tests use xpcomglue, rev. 1

Comment 2

[Benjamin Smedberg]

Fixed on trunk.

Comment 3

[David G King]

This fix seems to have broken my Fedora Core 4 build and the luna tinderbox build.

Comment 4

[David G King]

Fixed

Comment 5

[Pete Zha]

This patch caused the bustage on Solaris
gmake[5]: Leaving directory `/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla/parser/htmlparser/src'
gmake[5]: Entering directory `/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla/parser/htmlparser/tests'
gmake[6]: Entering directory `/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla/parser/htmlparser/tests/grabpage'
grabpage.cpp
CC -o grabpage.o -c  -DOSTYPE=\"SunOS5\" -DOSARCH=\"SunOS\" -DBUILD_ID=2005121305  -I../../../../dist/include/xpcom -I../../../../dist/include/string -I../../../../dist/include/necko -I../../../../dist/include -I../../../../dist/include -I../../../../dist/include/nspr    -I../../../../dist/sdk/include -I/usr/openwin/include   -KPIC  -I/usr/openwin/include -xbuiltin=%all -features=tmplife -norunpath -mt  -DNDEBUG -DTRIMMED -xO4  -I/usr/openwin/include -DMOZILLA_CLIENT -D_MOZILLA_CONFIG_H_ -DMOZILLA_VERSION=\"1.9a1\" -DMOZILLA_VERSION_U=1.9a1 -DSOLARIS=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1 -DHAVE_DIRENT_H=1 -DHAVE_SYS_BYTEORDER_H=1 -DHAVE_GETOPT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1 -DHAVE_X11_XKBLIB_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1 -DHAVE_LIBSOCKET=1 -DFUNCPROTO=15 -DHAVE_XSHM=1 -D_REENTRANT=1 -DHAVE_RANDOM=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1 -DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_STAT64=1 -DHAVE_LSTAT64=1 -DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1 -DHAVE_LANGINFO_CODESET=1 -DVA_COPY=va_copy -DHAVE_VA_COPY=1 -DHAVE_I18N_LC_MESSAGES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk2\" -DMOZ_WIDGET_GTK2=1 -DMOZ_ENABLE_XREMOTE=1 -DMOZ_X11=1 -DMOZ_SUITE=1 -DMOZ_BUILD_APP=suite -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DMOZ_ENABLE_XFT=1 -DMOZ_ENABLE_GNOMEUI=1 -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_XTF=1 -DMOZ_MATHML=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_LOGGING=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1 -DMOZ_ACCESSIBILITY_ATK=1 -DMOZILLA_LOCALE_VERSION=\"1.9a1\" -DMOZILLA_REGION_VERSION=\"1.9a1\" -DMOZILLA_SKIN_VERSION=\"1.8\"  grabpage.cpp
CC -o grabpage -I/usr/openwin/include -xbuiltin=%all -features=tmplife -norunpath -mt  -DNDEBUG -DTRIMMED -xO4  grabpage.o   -xildoff -zlazyload -zcombreloc  -R '$ORIGIN:$ORIGIN/..'   -L../../../../dist/bin -L../../../../dist/lib ../../../../dist/lib/libxpcomglue_s.a -L../../../../dist/bin -lxpcom -lxpcom_core  -L../../../../dist/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl -lposix4  -lsocket -ldl -lm      
/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla/config/nsinstall -R -m 755 grabpage ../../../../dist/bin
gmake[6]: Leaving directory `/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla/parser/htmlparser/tests/grabpage'
gmake[6]: Entering directory `/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla/parser/htmlparser/tests/html'
TestParser.cpp
CC -o TestParser.o -c  -DOSTYPE=\"SunOS5\" -DOSARCH=\"SunOS\" -DBUILD_ID=2005121305 -I./../../public -I../../../../dist/include/xpcom -I../../../../dist/include/string -I../../../../dist/include/necko -I../../../../dist/include/content -I../../../../dist/include -I../../../../dist/include -I../../../../dist/include/nspr    -I../../../../dist/sdk/include -I/usr/openwin/include   -KPIC  -I/usr/openwin/include -xbuiltin=%all -features=tmplife -norunpath -mt  -DNDEBUG -DTRIMMED -xO4  -I/usr/openwin/include -DMOZILLA_CLIENT -D_MOZILLA_CONFIG_H_ -DMOZILLA_VERSION=\"1.9a1\" -DMOZILLA_VERSION_U=1.9a1 -DSOLARIS=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1 -DHAVE_DIRENT_H=1 -DHAVE_SYS_BYTEORDER_H=1 -DHAVE_GETOPT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1 -DHAVE_X11_XKBLIB_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1 -DHAVE_LIBSOCKET=1 -DFUNCPROTO=15 -DHAVE_XSHM=1 -D_REENTRANT=1 -DHAVE_RANDOM=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1 -DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_STAT64=1 -DHAVE_LSTAT64=1 -DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1 -DHAVE_LANGINFO_CODESET=1 -DVA_COPY=va_copy -DHAVE_VA_COPY=1 -DHAVE_I18N_LC_MESSAGES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk2\" -DMOZ_WIDGET_GTK2=1 -DMOZ_ENABLE_XREMOTE=1 -DMOZ_X11=1 -DMOZ_SUITE=1 -DMOZ_BUILD_APP=suite -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DMOZ_ENABLE_XFT=1 -DMOZ_ENABLE_GNOMEUI=1 -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_XTF=1 -DMOZ_MATHML=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_LOGGING=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1 -DMOZ_ACCESSIBILITY_ATK=1 -DMOZILLA_LOCALE_VERSION=\"1.9a1\" -DMOZILLA_REGION_VERSION=\"1.9a1\" -DMOZILLA_SKIN_VERSION=\"1.8\"  TestParser.cpp
"../../../../dist/include/string/nsTAString.h", line 41: Error: #error Cannot use internal string classes without MOZILLA_INTERNAL_API defined. Use the frozen header nsStringAPI.h instead..
gmake[6]: *** [TestParser.o] Error 1
gmake[6]: Leaving directory `/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla/parser/htmlparser/tests/html'
gmake[5]: *** [libs] Error 2
gmake[5]: Leaving directory `/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla/parser/htmlparser/tests'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory `/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla/parser/htmlparser'
gmake[3]: *** [libs_tier_9] Error 2
gmake[3]: Leaving directory `/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla'
gmake[2]: *** [tier_9] Error 2
gmake[2]: Leaving directory `/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla'
gmake[1]: *** [alldep] Error 2
gmake[1]: Leaving directory `/export/home/tinderbox/builds/seamonkey-ports/SunOS_5.10_Clobber/mozilla'
gmake: *** [alldep] Error 2

Please see this tinderbox page for more information:
http://tinderbox.mozilla.org/SeaMonkey-Ports/