320134 - hang/crash due to an incorrect use of grid element (XUL) [@ nsIFrame::AddCSSPrefSize]

Status: RESOLVED WORKSFORME

(Toolkit :: UI Widgets, defect)

Description

[Gopal Venkatesan]

User-Agent:       Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.8) Gecko/20051130 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.8) Gecko/20051130 Firefox/1.5

The browser is totally unresponsive when the following XUL file is opened.  The cause of the unresponsiveness is due to the incorrect use of the Grid element (rows/columns).

<?xml version="1.0"?>
<?xml-stylesheet href="chrome://global/skin/" type="text/css"?>

<window id="test-grid-window" title="Grid Test" orient="horizontal"
	xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

    <grid>
	<columns>
	    <column/>
	    <column/>
	</columns>
	<rows>
	    <row>
		<column/>
		<column/>
	    </row>
	</rows>
    </grid>

</window>


Reproducible: Always

Steps to Reproduce:
1. Save the above code snippet as a XUL file.
2. Open firefox, and open the XUL file

Comment 1

[Steve England [:stevee]]

Attachment: testcase from comment 0

Comment 2

[Steve England [:stevee]]

Attachment: testcase from comment 0

The right attachment

Comment 3

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 ID:2005111116
I see the hang too.

Comment 4

[Steve England [:stevee]]

Actually I got a crash too.
TB12917734G [nsIFrame::AddCSSPrefSize]

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Was this fixed on trunk by one of dbaron's recent grid checkins?

Comment 6

[Steve England [:stevee]]

Yes, WFM Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051213 Firefox/1.6a1 ID:2005121305

Comment 7

[Gopal Venkatesan]

Apart from the browser unresponsiveness, its hitting 100% cpu time, bringing my system to a grind!

Comment 8

[Nickolay_Ponomarev]

Works fine here using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051224 Firefox/1.6a1

-> WFM

Gopalarathnam Venkatesan: Are you sure you tested with a trunk build?

Comment 9

[Gopal Venkatesan]

No, I didn't test with the latest trunk.  I built Firefox, Seamonkey from source (MOZILLA_1_8_BRANCH/BASE), both crashed.

Firefox build:
Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8) Gecko/20051201 Firefox/1.5

Seamonkey build:
Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8) Gecko/20051222 SeaMonkey/1.0b

The above are FreeBSD versions that I use at office.  They crash too.

Comment 10

[Nickolay_Ponomarev]

Yes, this crashes 1.8. However the code has been reworked on trunk and this does not crash there. This is the reason the bug was resolved as WFM. Please do not reopen it unless you still get the crash using a recent trunk build.

If you think this should be considered for one of 1.8 branches, you should try to get the bug that fixed this into 1.8 branch.