320183 - Optimize statement compilation

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Brett Wilson]

Some common code paths such as adding a URI use non-precompiled database statements. We should ensure that every statement used on common code paths have been precompiled.

Comment 1

[Brett Wilson]

The history system looks pretty good in this respect (at least when my patch to bug 325665 lands). I noticed the bookmark system could use some more precompiled statements. Probably the stuff for inserting new bookmarks and adjusting indices should all use precompiled statements. The deletion and folder manipulation is probably less critical. We don't want to precompile stuff that is seldom used.

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: for bookmarks service

This may negatively affect Ts in a very small way for normal startups. However it will improve perf generally for each of these APIs, as we won't be compiling the statements at call-time. It should also improve performance of bookmarks import and folder sorting, where we call these APIs hundreds or thousands of times in succession.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 287697 [details] [diff] [review]
for bookmarks service

r=sspitzer

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 287697 [details] [diff] [review]
for bookmarks service

drivers: see comment #2

Comment 5

[(not reading, please use [e-mail] instead)]

from irc:

<dietrich> import for me involves 1000+ items, which means we're creating,
compiling and destroying 2000+ statements

So, this is a good fix for improving performance on first time running Fx 3
(from Fx 2)

About impacting Ts, I asked dietrich if we call ::Init() before the browser
shows up, or if we call it from delayedStartup().  He reminded me that we do,
from _initPlaces(), in nsBrowserGlue.js

(Even still, we are both doubtful that compiling these statements is going to
move the Ts needle at all.)

Comment 6

[Damon Sicore (:damons)]

Comment on attachment 287697 [details] [diff] [review]
for bookmarks service

a=release drivers

Comment 7

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavBookmarks.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp,v  <--  nsNavBookmarks.cpp
new revision: 1.126; previous revision: 1.125
done
Checking in toolkit/components/places/src/nsNavBookmarks.h;
/cvsroot/mozilla/toolkit/components/places/src/nsNavBookmarks.h,v  <--  nsNavBookmarks.h
new revision: 1.48; previous revision: 1.47
done

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv