Closed
Bug 320258
Opened 19 years ago
Closed 19 years ago
id: searchResultListBox appears twice in SearchDialog.xul
Categories
(MailNews Core :: Search, defect)
MailNews Core
Search
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcow, Unassigned)
Details
Attachments
(2 files, 1 obsolete file)
1.11 KB,
patch
|
mcow
:
review+
mcow
:
superreview+
|
Details | Diff | Splinter Review |
4.94 KB,
patch
|
Details | Diff | Splinter Review |
Right after the splitter, the XUL file for the Search Messages dialog has:
<vbox id="searchResultsListBox" flex="4" persist="height">
<vbox id="searchResultListBox" flex="1">
This results in the margin for the listbox itself also being applied to the
vbox containing the listbox and the buttons below it, with an awkward-looking inset.
Changing the first 'searchResultsListBox' to e.g. 'searchResultsBox' would fix this without impacting anything else -- the only rules are the margin and a height.
Reporter | ||
Comment 1•19 years ago
|
||
This is a patch against the version I've got in my downloaded TB 1201 trunk build. I don't know if this file is forked against the Seamonkey version, but it's pretty straightforward.
Attachment #205836 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 2•19 years ago
|
||
Comment on attachment 205836 [details] [diff] [review]
non-CVS diff // TB 1.6a1-1201
Note that the upper box's id is searchTerms so perhaps this one should be searchResults? Also, ABSearchDialog.xul (both versions) needs fixing.
Attachment #205836 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Reporter | ||
Updated•19 years ago
|
Attachment #205836 -
Flags: superreview?(bienvenu)
Comment 3•19 years ago
|
||
Comment on attachment 205836 [details] [diff] [review]
non-CVS diff // TB 1.6a1-1201
I can check this in if you like...
Attachment #205836 -
Flags: superreview?(bienvenu) → superreview+
Reporter | ||
Comment 4•19 years ago
|
||
Actually, here's a patch updated per comment 2: changed the id name, and added the fix for abSearchDialog.xul as well. Carrying forward the r/sr.
Yes, David, I'd appreciate it if you'd check this in, at least for TB; but the change should be made for Seamonkey as well.
Attachment #205836 -
Attachment is obsolete: true
Attachment #207656 -
Flags: superreview+
Attachment #207656 -
Flags: review+
Comment 5•19 years ago
|
||
Comment 6•19 years ago
|
||
fix checked in, thx, Mike.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•