320258 - id: searchResultListBox appears twice in SearchDialog.xul

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[Mike Cowperthwaite]

Right after the splitter, the XUL file for the Search Messages dialog has:

    <vbox id="searchResultsListBox" flex="4" persist="height">
      <vbox id="searchResultListBox" flex="1">

This results in the margin for the listbox itself also being applied to the 
vbox containing the listbox and the buttons below it, with an awkward-looking inset.

Changing the first 'searchResultsListBox' to e.g. 'searchResultsBox' would fix this without impacting anything else -- the only rules are the margin and a height.

Comment 1

[Mike Cowperthwaite]

Attachment: non-CVS diff // TB 1.6a1-1201

This is a patch against the version I've got in my downloaded TB 1201 trunk build.  I don't know if this file is forked against the Seamonkey version, but it's pretty straightforward.

Comment 2

[[e-mail]]

Comment on attachment 205836 [details] [diff] [review]
non-CVS diff // TB 1.6a1-1201

Note that the upper box's id is searchTerms so perhaps this one should be searchResults? Also, ABSearchDialog.xul (both versions) needs fixing.

Comment 3

[David :Bienvenu]

Comment on attachment 205836 [details] [diff] [review]
non-CVS diff // TB 1.6a1-1201

I can check this in if you like...

Comment 4

[Mike Cowperthwaite]

Attachment: non-CVS diff // TB 1.6a1-0105

Actually, here's a patch updated per comment 2: changed the id name, and added the fix for abSearchDialog.xul as well.  Carrying forward the r/sr.  
Yes, David, I'd appreciate it if you'd check this in, at least for TB; but the change should be made for Seamonkey as well.

Comment 5

[Karsten Düsterloh]

Attachment: CVS patch of the above

Comment 6

[David :Bienvenu]

fix checked in, thx, Mike.