Closed
Bug 320304
Opened 20 years ago
Closed 20 years ago
Crash on OS/2 due to long canvas
Categories
(Core :: Graphics: Canvas2D, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
(Keywords: crash)
As noted in bug 315207 a canvas enabled OS/2 build crashes when trying to allocate a large canvas. Citing from bug 319235 (equivalent of this one for Gtk+):
the javascript from the patch does (effectively):
ctx.drawWindow(win, 0, 0, 1487, 50660, "rgb(255,255,255)");
and Canvas happily attempts to allocate an offscreen 1487x50660
pixmap (which fails, of course).
| Assignee | ||
Comment 1•20 years ago
|
||
I just tested this problem again on trunk, just changing the w/h values at
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/global/resources/content/bindings/tabbrowser.xml&rev=1.161&mark=262#262
to 10000 and 20000, and I never got a crash again. If large values are given to nsOffscreenSurface::Init() then the GpiCreateBitmap() call at
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/gfx/src/os2/nsDrawingSurfaceOS2.cpp&rev=1.30&mark=224#188
always correctly returns GPI_ERROR. No idea why it has crashed before...
Still have to test with 1.8 branch.
Severity: normal → minor
| Assignee | ||
Comment 2•20 years ago
|
||
OK, works on branch, too. So resolving as WFM.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → WORKSFORME
Version: Other Branch → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•