Remove mFrameConstructor member from nsListBoxBodyFrame

RESOLVED FIXED

Status

()

Core
Layout
--
minor
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Vidar Haarr (not reading bugmail), Assigned: Vidar Haarr (not reading bugmail))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
nsListBoxBodyFrame has a |nsCSSFrameConstructor* mFrameConstructor| member, it could just get it from |GetPresContext()->PresShell()->FrameConstructor()| when needed.
(Assignee)

Comment 1

13 years ago
Created attachment 205930 [details] [diff] [review]
version 1

Something like this?

I have to admit, I don't know what |class nsCSSFrameConstructor;| bit in nsListBoxBodyFrame.h does, I just noticed that it compiled fine when I removed it -- perhaps you can explain what that does, generally speaking?
Attachment #205930 - Flags: review?(roc)
"class nsCSSFrameConstructor;" basically says "nsCSSFrameConstructor is a class" and nothing more. You can then create pointers and references to it, but you can't access any fields or methods, or subclass from it, or call "new nsCSSFrameConstructor", etc etc without pulling in a real definition (from nsCSSFrameConstructor.h). xul/base/src/nsListBoxBodyFrame.h was using this so it could mention "nsCSSFrameConstructor*" in the places you removed (more efficient that doing a full #include "nsCSSFrameConstructor.h").
(Assignee)

Comment 3

13 years ago
Ah, thank you.
Attachment #205930 - Flags: superreview+
Attachment #205930 - Flags: review?(roc)
Attachment #205930 - Flags: review+
(Assignee)

Comment 4

13 years ago
roc: Could you help me with the checkin, too ? :-)
checked in. We should think about getting you CVS access sometime.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.