"3-form" of patch()needs parameter for file to be patched.

RESOLVED WONTFIX

Status

Core Graveyard
Installer: XPInstall Engine
P3
normal
RESOLVED WONTFIX
18 years ago
2 years ago

People

(Reporter: David Epstein, Assigned: dveditz)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
I found this one looking at the source code:
http://lxr.mozilla.org/seamonkey/source/xpinstall/src/nsInstallPatch.cpp
lines 70-112.

This form of patch()has 3 parameters: patch(String regName, String versInfo, 
String jarSrc). jarSrc is the .gdf file that is the diff btwn the original file 
and the patched file.

To try this out:
1. Go to http://jimbob/trigger2.html.
2. Trigger http://jimbob/jars/f_addunixpatch.xpi (installs the original file).
3. Trigger http://jimbob/jars/f_unixpatch2.xpi (uses the 3-form for patching).
Result: -229 script error. install (patching) fails.

Possibilities: 
a) Add the patch file parameter "inPartialPath" (like in the 5 form: see line 
115) to make it a 4-form.
b) Add the patch file parameter "inPartialPath" and remove the versInfo param 
(since we don't really need it here) to keep it a 3-form.

note: in the same code, line 99, the variable "folderSpec" is used even though 
it's not a parameter imput for this form. This is the return folder object.

Updated

18 years ago
Target Milestone: M15
(Assignee)

Comment 1

18 years ago
I'll take this one since it affects the API's we can support. By switching to 
string versions instead of objects we can no longer distinguish the signature
Assignee: cathleen → dveditz
Target Milestone: M15 → M16

Comment 2

18 years ago
need some clean up in the code
Target Milestone: M16 → M18
(Assignee)

Comment 3

17 years ago
Resetting target field for missed milestones
Target Milestone: M18 → ---

Comment 4

16 years ago
nsbeta1-.  No patching this time around.
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 5

10 years ago
The xpinstall script engine has been removed from the trunk, bugs in it are obsolete.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → WONTFIX
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.