32041 - "3-form" of patch()needs parameter for file to be patched.

Status: RESOLVED WONTFIX

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[David Epstein]

I found this one looking at the source code:
http://lxr.mozilla.org/seamonkey/source/xpinstall/src/nsInstallPatch.cpp
lines 70-112.

This form of patch()has 3 parameters: patch(String regName, String versInfo, 
String jarSrc). jarSrc is the .gdf file that is the diff btwn the original file 
and the patched file.

To try this out:
1. Go to http://jimbob/trigger2.html.
2. Trigger http://jimbob/jars/f_addunixpatch.xpi (installs the original file).
3. Trigger http://jimbob/jars/f_unixpatch2.xpi (uses the 3-form for patching).
Result: -229 script error. install (patching) fails.

Possibilities: 
a) Add the patch file parameter "inPartialPath" (like in the 5 form: see line 
115) to make it a 4-form.
b) Add the patch file parameter "inPartialPath" and remove the versInfo param 
(since we don't really need it here) to keep it a 3-form.

note: in the same code, line 99, the variable "folderSpec" is used even though 
it's not a parameter imput for this form. This is the return folder object.

Comment 1

[Daniel Veditz [:dveditz]]

I'll take this one since it affects the API's we can support. By switching to 
string versions instead of objects we can no longer distinguish the signature

Comment 2

[Cathleen]

need some clean up in the code

Comment 3

[Daniel Veditz [:dveditz]]

Resetting target field for missed milestones

Comment 4

[Jimmy Lee]

nsbeta1-.  No patching this time around.

Comment 5

[Daniel Veditz [:dveditz]]

The xpinstall script engine has been removed from the trunk, bugs in it are obsolete.