Closed
Bug 320540
Opened 19 years ago
Closed 19 years ago
Make GenerateJavaInterfaces.cpp work with the frozen string API
Categories
(Core Graveyard :: Java to XPCOM Bridge, defect)
Core Graveyard
Java to XPCOM Bridge
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
9.40 KB,
patch
|
jhpedemonte
:
review+
|
Details | Diff | Splinter Review |
We're going to stop exporting the nonfrozen symbols from libxul, so I had to convert GenerateJavaInterfaces to use the frozen string API (and the template hashtable classes).
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #206089 -
Flags: review?(jhpedemonte)
Comment 2•19 years ago
|
||
Comment on attachment 206089 [details] [diff] [review] Use frozen string API, rev. 1 In |ToUpperCase|, this line: + *end = toupper(*end); should read *buf = toupper(*buf); Otherwise, looks good.
Attachment #206089 -
Flags: review?(jhpedemonte) → review+
Assignee | ||
Comment 3•19 years ago
|
||
Heh, yes. Fixed on trunk; this doesn't need to go on any branches.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•