320549 - MySQL 5 Unsupported in Bugzilla releases prior to 2.20RC1

Status: RESOLVED FIXED

(Bugzilla :: Documentation, defect)

Description

[Kevin Benton]

Due to a change in MySQL 5.0.12, implicit joins frequently cause syntax errors in MySQL.  Therefore, we need to let users know that we do not support upgrading MySQL without upgrading Bugzilla if they have a Bugzilla version prior to 2.20RC1 when this issue was fixed (Search.pm change 1.89).  This bug addresses the docuemntation update for installation.xml in 2.18.4 but we should consider the value of applying the same updates to the current 2.16 release.

Comment 1

[Kevin Benton]

Attachment: Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.18.4)

Comment 2

[Kevin Benton]

Attachment: 206107: Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.16.10)

Comment 3

[Kevin Benton]

Attachment: 206109: 206107: Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.16.10)

Comment 4

[Kevin Benton]

Comment on attachment 206112 [details] [diff] [review]
206109: 206107: Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.16.10)

Submitting unified diff per Fred's request.

Comment 5

[Kevin Benton]

Comment on attachment 206107 [details] [diff] [review]
Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.18.4)

Submitting unified diff per Fred's request.

Comment 6

[Kevin Benton]

Attachment: 206107: Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.18.4)

Comment 7

[Kevin Benton]

Attachment: 206107: Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.16.10)

Comment 8

[Max Kanat-Alexander]

Comment on attachment 206114 [details] [diff] [review]
206107: Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.18.4)

You can't r+ your own patch.

Comment 9

[Colin Ogilvie [:cso]]

> Note that Bugzilla prior to 2.20RC1 does not work with MySQL 5.0.12 or higher.   > If you intend to install Bugzilla using MySQL 5.x as your back-end, please use a
> more current release of Bugzilla.

I think I'd prefer:

"Note that versions of Bugzilla prior to 2.20RC1 do not work with MySQL 5.0.12 or higher. If you intend to install Bugzilla using MySQL 5.x as your back-end, please use a more current release of Bugzilla."

Comment 10

[Kevin Benton]

(In reply to comment #9)
> > Note that Bugzilla prior to 2.20RC1 does not work with MySQL 5.0.12 or higher.   > If you intend to install Bugzilla using MySQL 5.x as your back-end, please use a
> > more current release of Bugzilla.
> 
> I think I'd prefer:
> 
> "Note that versions of Bugzilla prior to 2.20RC1 do not work with MySQL 5.0.12
> or higher. If you intend to install Bugzilla using MySQL 5.x as your back-end,
> please use a more current release of Bugzilla."

From what I read here, it seems the only changes you suggest are

s/Note that Bugzilla/Note that versions of Bugzilla/
s/RC1 does/RC1 do/

correct Colin?  I agree - that's better wording.  Anyone else before I submit an updated pair of patches?  Note that the wording is identical in both the 2.16.10 and 2.18.4 updates.

Comment 11

[Colin Ogilvie [:cso]]

(In reply to comment #10)
> correct Colin?  I agree - that's better wording.  Anyone else before I submit
> an updated pair of patches?

I think thats all.

Comment 12

[Kevin Benton]

Attachment: Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.18.4)

Changes per Max's suggestions.

Comment 13

[Kevin Benton]

Attachment: Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.16.10)

Changes suggested by Max.  Note that this patch also encourages first-time installers to upgrade from 2.16.x to a more current version as 2.16.x is soon to become unsupported.

Comment 14

[Colin Ogilvie [:cso]]

Comment on attachment 206338 [details] [diff] [review]
Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.18.4)

Nit: Please only use 1 space after a full stop. Such that "higher.  If" becomes "higher. If"

r=me by inspection - if you submit a followup patch fixing this, please feel free to carry the review forward if that is all that changes.

Comment 15

[Frédéric Buclin]

*** Bug 321061 has been marked as a duplicate of this bug. ***

Comment 16

[Vlad Dascalu]

Comment on attachment 206340 [details] [diff] [review]
Patch to fix installation.xml showing MySQL5 as unsupported with Bugzilla prior to 2.20RC1. (against 2.16.10)

-      <para>If you are using MySQL 4.0 or newer, enter:</para>
+      <para>If you are using MySQL 4.x, enter:</para>

I think I'm missing something, but what should we enter for MySQL 5.0 or newer? "or newer" actually made sense.

Looks good except for the nit above (could be fixable on checkin, or you can carry the review if/when you upload a new patch)

Comment 17

[Vlad Dascalu]

I've addressed the nits upon checkin (including Colin's suggestion).

Checking in docs/xml/installation.xml;
/cvsroot/mozilla/webtools/bugzilla/docs/xml/installation.xml,v  <--  installation.xml
new revision: 1.18.2.28; previous revision: 1.18.2.27
done
Checking in docs/xml/installation.xml;
/cvsroot/mozilla/webtools/bugzilla/docs/xml/installation.xml,v  <--  installation.xml
new revision: 1.72.2.25; previous revision: 1.72.2.24
done

Comment 18

[Colin Ogilvie [:cso]]

(In reply to comment #16)
> (From update of attachment 206340 [details] [diff] [review] [edit])
> -      <para>If you are using MySQL 4.0 or newer, enter:</para>
> +      <para>If you are using MySQL 4.x, enter:</para>
> 
> I think I'm missing something, but what should we enter for MySQL 5.0 or newer?
> "or newer" actually made sense.

To me, "MySQL 4.0 or newer" includes MySQL 5.0 as MySQL 5.0 is newer than MySQL 4.