320639 - show dropIndicator for D&D on to tabbar

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, enhancement)

Description

[Peter van der Woude [:Peter6]]

If we drag a bookmark/url onto the tabbar the dropIndicator is not displayed.
This is inconsistent with the behaviour of reordering tabs.

(for this functionality see e.g. the tabsidebar extension 
http://users.blueprintit.co.uk/~dave/web/firefox/tabsidebar/index.html )

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Does this depend on bug 320638?

Comment 2

[Ian Macfarlane]

It must do, as currently you can't drag it (which is what bug 320638 is about).

Comment 3

[Dave Townsend [:mossop]]

I don't see why this depends on bug 320638. You can currently drag a url and drop it onto any tab. The point I think is to get an indication of where that url will end up. Following the original example, the way Tab Sidebar does it is to display the standard tab drop arrow over the top of the tab. Bug 320630 is about being able to drop URL's in between tabs to create a whole new tab.

Comment 4

[Wayne Woods]

Yeah, it doesn't depend on bug 320638, but it makes sense for both to be implemented at the same time.

I've just added a patch over on that bug which allows both dnd between tabs and activates the drop indicator for URI dnd. If you guys could please test it out, that'd be great!

Comment 5

[Daniel C]

This WFM. Anyone still seeing this?

Comment 6

[Wayne Woods]

The indicator does appear now, so WFM. It seems to be a buggy implementation (dragging URLs over the tab bar can sometimes leave the indicator pointing to the wrong place), but it still appears. I'll close this one, as any improvements should be handled by other bugs.