Paralleling http://lxr.mozilla.org/mozilla/source/browser/config/mozconfig we should have a very simple suite/config/mozconfig in the tree. Patch comes up in a minute.
Created attachment 206301 [details] [diff] [review] patch: add mozconfig file Here's the patch for adding this mozconfig file. The place in suite/config was chosen to fit what other apps have (firefox, thunderbird, etc.)
fwiw I disagree that we need this
Hmm? Why? I see it makes much easier to create multi-app .mozconfig's since now I can simply make a switch between several /app/config/mozconfig files to include.
ok, I retract comment 1 :) that's a good usecase.
You can do that without a template: case "$gandalf_product" in suite) ac_add_options --enable-application=suite mk_add_options MOZ_OBJDIR=obj-sm ;; browser) ac_add_options --enable-application=browser mk_add_options MOZ_OBJDIR=obj-fx ;; *) echo "gandalf_product not set!"; exit 1 ;; I don't particularly like the template mozconfigs and if it weren't already entrenched in historical configurations I would have attempted to remove the browser/mail stubs (now that the build defaults are coded into configure directly, instead of being in the mozconfig files).
(In reply to comment #5) > You can do that without a template: (...) I could, but this way, it's me who decides about what should be ON by default, and in mozconfig case, I just include the file that should choose defaults on behalf of me.
note that the mozconfigs are just two lines and won't change (which is the reason for my comment 1). the real decision what gets enabled is in the configure script.
Comment on attachment 206301 [details] [diff] [review] patch: add mozconfig file imho not an r+sr candidate
How about if we add a template suiterunner mozconfig?
WONTFIX per comment #5
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.