add a template mozconfig file into suite/

RESOLVED WONTFIX

Status

SeaMonkey
Build Config
RESOLVED WONTFIX
13 years ago
11 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
Paralleling http://lxr.mozilla.org/mozilla/source/browser/config/mozconfig we should have a very simple suite/config/mozconfig in the tree.

Patch comes up in a minute.
(Assignee)

Comment 1

13 years ago
Created attachment 206301 [details] [diff] [review]
patch: add mozconfig file

Here's the patch for adding this mozconfig file. The place in suite/config was chosen to fit what other apps have (firefox, thunderbird, etc.)
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #206301 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #206301 - Flags: review?(neil.parkwaycc.co.uk)
fwiw I disagree that we need this
Hmm? Why? I see it makes much easier to create multi-app .mozconfig's since now I can simply make a switch between several /app/config/mozconfig files to include.
ok, I retract comment 1 :) that's a good usecase.

Comment 5

13 years ago
You can do that without a template:

case "$gandalf_product" in
suite)
  ac_add_options --enable-application=suite
  mk_add_options MOZ_OBJDIR=obj-sm
  ;;

browser)
  ac_add_options --enable-application=browser
  mk_add_options MOZ_OBJDIR=obj-fx
  ;;

*)
  echo "gandalf_product not set!";
  exit 1
  ;;

I don't particularly like the template mozconfigs and if it weren't already entrenched in historical configurations I would have attempted to remove the browser/mail stubs (now that the build defaults are coded into configure directly, instead of being in the mozconfig files).
(In reply to comment #5)
> You can do that without a template:

(...)

I could, but this way, it's me who decides about what should be ON by default, and in mozconfig case, I just include the file that should choose defaults on behalf of me.
note that the mozconfigs are just two lines and won't change (which is the reason for my comment 1). the real decision what gets enabled is in the configure script.

Comment 8

13 years ago
Comment on attachment 206301 [details] [diff] [review]
patch: add mozconfig file

imho not an r+sr candidate
Attachment #206301 - Flags: review?(neil.parkwaycc.co.uk)

Comment 9

12 years ago
How about if we add a template suiterunner mozconfig?
(Assignee)

Comment 10

11 years ago
WONTFIX per comment #5
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

11 years ago
Attachment #206301 - Flags: superreview?(neil)
You need to log in before you can comment on or make changes to this bug.