Closed Bug 320836 Opened 19 years ago Closed 19 years ago

make clean doesn't kill fake-import(.exp)

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file, 1 obsolete file)

cvs trunk from friday.

i'm doing a make in a directory managed by the mozilla build system, but when i do make clean the fake-import/fake-import.exp files aren't removed.
Attached patch add to garbage (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: UNCONFIRMED → ASSIGNED
Attachment #206394 - Flags: review?(benjamin)
Attachment #206394 - Flags: review?(benjamin) → review+
Comment on attachment 206394 [details] [diff] [review]
add to garbage

mozilla/config/config.mk 	3.346
Attachment #206394 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
The intention appears to have been to delete the fake files immediately.
Note that link creates both fake import and export libraries, and I thought fake-import.exp was somewhat silly which is why I trimmed it to fake.
Attachment #207269 - Flags: review?(benjamin)
Comment on attachment 207269 [details] [diff] [review]
Don't leave fake files lying around

That wasn't the goal, but this works just as well, or better.
Attachment #207269 - Flags: review?(benjamin) → review+
Comment on attachment 207269 [details] [diff] [review]
Don't leave fake files lying around

Fix checked in on the trunk.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: