320869 - cvs remove unused calendar files

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

calendar doesn't use jslib anymore, so it should be cvs removed. That would stop it from showing up in lxr searches.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Morphing this bug to cover all unused files

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

List of files i could find:

resources/content/dayView.*
resources/content/weekView.*
resources/content/monthView.*
resources/content/multiweekView.*
resources/content/jslib/*
resources/content/calendarEvent.js
resources/content/test/*
resources/content/eventDialog.*
resources/content/localCalDialog.*
resources/content/serverDialog.*

There might be more...

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch part1

patch needed to be able to remove calendarEvent.js

Comment 4

[Joey Minta]

Comment on attachment 211613 [details] [diff] [review]
patch part1

r=jminta for removing this code.  Also for cvs-removing the list of files you gave.  Additionally:
resources/dragDrop.js and resources/importExport.js

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Patch checked in, files removed.
closing this bug, we can file new bugs for new files.

Comment 6

[gekacheka]

Please let us know if there is a way we can search the old source code now.
Is there a way to search a non-current version/fork?

The old source is useful for fixing regressions, and seeing how things worked before (including after a release, when more users complain).

Comment 7

[Joey Minta]

(In reply to comment #6)
> Please let us know if there is a way we can search the old source code now.
> Is there a way to search a non-current version/fork?

I talked about this with mvl prior to this removal.  Apparently Bonsai can search the Attic.  You can also search the 1.8.0 branch http://lxr.mozilla.org/mozilla1.8.0/ or download the 0.3a1 source http://ftp.mozilla.org/pub/mozilla.org/calendar/sunbird/releases/0.3a1/source/

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

Bonsai:
http://bonsai.mozilla.org/rview.cgi?dir=mozilla/calendar/resources/content/Attic&cvsroot=/cvsroot&module=default

Comment 9

[Reed Loden [:reed]]

The bugspam monkeys have struck again. They are currently chewing on default assignees for Calendar. Be afraid for your sanity!