320935 - Download Manager incorrectly shows status of downloaded file as "Done" even if the downloaded file is corrupt

Status: RESOLVED INCOMPLETE

(Toolkit :: Downloads API, defect)

Description

[montylee]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

The Download Manager incorrectly reports the status of downloaded files as "Done" even if the file was not downloaded properly i.e. even if the downloaded file size doesn't match the original file size. For e.g. i tried to download a 700KB file and the Download Manager reported the file status as "Done". When i checked the file size it was 400KB.

Reproducible: Sometimes

Steps to Reproduce:
1. Try to download files of various sizes from various sources.
2. 
3.
Actual Results:  
Even if the files are not downloaded fully i.e. the downloaded file size doesn't match the original file size as shown by the Download Manager, it reports the status of the file as "Done".

Expected Results:  
The Download Manager should have reported the status as "Error" and should have given the option to the user to retry or cancel the download.


Theme: SphereGnome

Comment 1

[zug_treno]

Duplicate of (bug 301595 ->) Core bug 237623?

Comment 2

[Heinz Iten]

I have this problem often - mainly on files larger than about 500KB. It has been a nuisance since version 1.0...
If forces me to use a download manager - with FlashGot it works great, but can't you just fix this!?

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Have you guys tried with the latest trunk nightly candidates of Firefox 3?

ftp://ftp.mozilla.org/pub/firefox/nightly/latest-trunk/

Comment 4

[Martin Sall]

I have Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071025 Firefox/2.0.0.9
and I can confirm that it is happening to me, too.
How to reproduce the bug:
1.start downloading some big file (for example this one: http://www.ibiblio.org/jmaynard/turnkey-mvs-3.zip)
2.disable your network connection (to simulate situation when the network is down, which happens often where I live).
What happens - the Download Manager says the file is Done. I think, it should say - "Sorry, download failed", or "Connection failure", and offer to resume download.
If other download managers can resume HTTP downloads, it is really shame for Firefox to fail in such a way :(  Especially because this bug has many duplicates long time ago (I saw one similar in year 2004.). And it is not fixed yet.
I really, really would like to use Firefox instead of using Firefox and FlashGet.
Maybe GNU/Linux users have something to say, maybe this is only Windows-related issue?
BTW, it seems working with ftp - I was downloading the nightly build when the connection went down. But downloading was not interrupted and finished well.

There is a difference when network goes down and when the connection is disabled, if you are downloading from FTP - disabling the connection gives an error message that warns about the failure (but still no way to resume download, you have to retry it from the beginning). When downloading from HTTP, there is NO such a warning in the same situation, the download just tells it is Done ok. 
Ok, I 'll try the nightly build, hope it helps.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

I just tested this, and the latest Firefox 3 nightly build was resilient; I killed my wireless connection while downloading the ZIP file in comment 4, and it auto-resumed without problems.

Comment 6

[Shawn Wilsher :sdwilsh]

Resolving old UNCONFIRMED Download Manager bugs as INCOMPLETE.  If you still see this issue, please reopen.

To mark all these bug changes as read, filter on ONOMATOPOEIA.

Comment 7

[t8av]

The Download manager should indicate whenever downloaded file size is different from expected file size (the second one is presented since the beginning of the download).